Re: Proof of concept for fluent bindings for ObservableValue

2021-10-04 Thread John Hendrikx
On 04/10/2021 20:37, Michael Strauß wrote: A little bit of bikeshedding here: I think this feature should be thought of as a type-safe version of `Bindings.select`, which should also be reflected in the terminology used (i.e. not map/flatMap). The terminology, combined with the frequent

Re: Proof of concept for fluent bindings for ObservableValue

2021-10-04 Thread John Hendrikx
On 04/10/2021 17:51, Nir Lisker wrote: I think that a PR can be created. The only point we need to decide is about the subscription models we talked about above. ReactFX uses something different for each, you use the same. That can determine if we need different classes for each binding type.

Re: Proof of concept for fluent bindings for ObservableValue

2021-10-04 Thread Michael Strauß
A little bit of bikeshedding here: I think this feature should be thought of as a type-safe version of `Bindings.select`, which should also be reflected in the terminology used (i.e. not map/flatMap). The terminology, combined with the frequent comparisons to reactive libraries might make it seem

Re: Proof of concept for fluent bindings for ObservableValue

2021-10-04 Thread Nir Lisker
I think that a PR can be created. The only point we need to decide is about the subscription models we talked about above. ReactFX uses something different for each, you use the same. That can determine if we need different classes for each binding type. I can create the JBS issue for this one

Re: RFR: 8274137: TableView scrollbar/header misaligned when reloading data [v3]

2021-10-04 Thread Ajit Ghaisas
On Mon, 27 Sep 2021 05:27:25 GMT, Robert Lichtenberger wrote: >> This PR fixes JDK-8274137 by removing the optimization from updateHbar() >> that will no-op the method in case the VirtualFlow is invisible or currently >> has no scene. >> Since changes to the hBar's value can happen even if

Re: RFR: 8252936: Optimize removal of listeners from ExpressionHelper.Generic [v3]

2021-10-04 Thread John Nader
On Sat, 2 Oct 2021 13:35:51 GMT, Kevin Rushforth wrote: >> The behavior is the same between openjdk 16.0.2 and 17.0.0.1. The test to >> recreate the problem adds many nodes (Rectangle) to a parent Group. The >> process causes each node to add two invalidation listeners (disabledProperty >>

Integrated: 8274433: All Cells: misbehavior of startEdit

2021-10-04 Thread Jeanette Winzenburg
On Thu, 30 Sep 2021 12:00:16 GMT, Jeanette Winzenburg wrote: > The misbehavior happens if (super) startEdit didn't succeed (== > !cell.isEditing): > > - must not fire editStart event > - must not update control's editing location > > fix is to back out of startEdit if super.startEdit doesn't

Re: RFR: 8274433: All Cells: misbehavior of startEdit [v2]

2021-10-04 Thread Ajit Ghaisas
On Fri, 1 Oct 2021 14:59:02 GMT, Jeanette Winzenburg wrote: >> The misbehavior happens if (super) startEdit didn't succeed (== >> !cell.isEditing): >> >> - must not fire editStart event >> - must not update control's editing location >> >> fix is to back out of startEdit if super.startEdit

How to publish sources and javadoc?

2021-10-04 Thread Florian Kirmaier
Hi everyone, When I use the task sdk / publish / publishToMavenLocal, I can not see a jar with the sources. But they are always part of the official JavaFX release: https://repo1.maven.org/maven2/org/openjfx/javafx-controls/17.0.0.1/ And the javadoc also deems to be missing. How can the javadoc

Re: Enhancements for JavaFX 18

2021-10-04 Thread John Hendrikx
I missed this question. There are several external libaries available to help with these kinds of bindings. There is EasyBind, ReactFX and an attempt of my own (https://github.com/hjohn/hs.jfx.eventstream). They all have a different way of addressing this, but they do all have one thing in

RFR: 8274669: Dialog sometimes ignores max height

2021-10-04 Thread Marius Hanl
This PR fixes a visual glitch which may happen when showing a dialog. When a max height is set and the pref height of the dialog content is bigger the dialog starts to flicker between the max height and the pref height. This happens because in one case the height is not bound between the min and

Re: RFR: 8252936: Optimize removal of listeners from ExpressionHelper.Generic [v3]

2021-10-04 Thread Kevin Rushforth
On Fri, 1 Oct 2021 21:11:01 GMT, John Nader wrote: > Here is the minimal application I am using to recreate the issue. I'll attach the test case you provided to the bug report. > The question now is should the work done on this PR be abandoned. It > addresses a current performance limitation

Re: RFR: 8252936: Optimize removal of listeners from ExpressionHelper.Generic [v3]

2021-10-04 Thread John Nader
On Wed, 14 Apr 2021 12:33:23 GMT, dannygonzalez wrote: >> https://bugs.openjdk.java.net/browse/JDK-8185886 >> >> Optimisation to ExpressionHelper.Generic class to use Sets rather than >> Arrays to improve listener removal speed. >> >> This was due to the removal of listeners in TableView