On Thu, 30 Sep 2021 12:00:16 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
> The misbehavior happens if (super) startEdit didn't succeed (== > !cell.isEditing): > > - must not fire editStart event > - must not update control's editing location > > fix is to back out of startEdit if super.startEdit doesn't switch the cell > into editing mode > > Added tests that failed/passed before/after the fix. Note that for Tree-, > Table-, TreeTableCell one of the added tests would be a false green due to > those cells not updating the editing location on its control > [JDK-8187474](https://bugs.openjdk.java.net/browse/JDK-8187474), so it's > ignore until that's fixed. This pull request has now been integrated. Changeset: 2c86e0fc Author: Jeanette Winzenburg <faste...@openjdk.org> URL: https://git.openjdk.java.net/jfx/commit/2c86e0fc81074f6ad49b798c891a358a5fe15f94 Stats: 105 lines in 8 files changed: 105 ins; 0 del; 0 mod 8274433: All Cells: misbehavior of startEdit Reviewed-by: mhanl, aghaisas ------------- PR: https://git.openjdk.java.net/jfx/pull/636