On Thu, 9 Apr 2020 09:37:30 GMT, Craig Cavanaugh
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8129123
>
> This pull request fixes JDK-8129123. This bug also effects Windows and Linux
> platforms.
> Also, I believe JDK-8196037 is a duplicate of this issue.
>
> I'v
On Fri, 17 Apr 2020 10:42:30 GMT, Jeanette Winzenburg
wrote:
> repeating my comment from the [previous pull
> request](https://github.com/openjdk/jfx/pull/136#issuecomment-608401086):
> I don't think this is yet ready for a technical review - there are some more
> basic questions that are not
On Fri, 17 Apr 2020 10:38:06 GMT, Ajit Ghaisas wrote:
>> Craig Cavanaugh has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update unit test for JDK_8129123 to check midpoint of the list
>
> modules/java
nux and
> Windows 10.
>
> Thanks!
Craig Cavanaugh has updated the pull request incrementally with one additional
commit since the last revision:
Update unit test for JDK_8129123 to check midpoint of the list
-
Changes:
- all: https://git.openjdk.java.net/jfx
On Tue, 14 Apr 2020 11:11:13 GMT, Kevin Rushforth wrote:
>> Thank you. I've updated the pull request comments with what I thought was
>> the necessary changes, but jcheck is still failing with
>>
>> "the commits in this PR have inconsistent user names and/or email
>> addresses. Please amend
https://bugs.openjdk.java.net/browse/JDK-8129123
This pull request fixes JDK-8129123. This bug also effects Windows and Linux
platforms.
Also, I believe JDK-8196037 is a duplicate of this issue.
I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and Windows
10.
Thanks!
On Thu, 16 Apr 2020 12:30:20 GMT, Kevin Rushforth wrote:
>> Seems I've made a further mess attempting to rebase. I apologize as I know
>> the list is not intended to be tech support for git usage, but I'm at a
>> loss and don't want to make it worse.
>>
>> Below is the log after an interactive
On Tue, 14 Apr 2020 09:04:40 GMT, Ajit Ghaisas wrote:
>> was: https://github.com/openjdk/jfx/pull/136
>
> I am taking a look at your changes now.
> @ccavanaugh can you make jcheck pass while I review. Please see the details
> of the failing jcheck.
Thank you. I've updated the pull request
> This pull request fixes JDK-8129123. This bug also effects Windows and Linux
> platforms.
> Also, I believe JDK-8196037 is a duplicate of this issue.
>
> I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and
> Windows 10.
>
> Thanks!
Craig
My use case which is driving the fix for this bug is user expectation in an
open source application (https://github.com/ccavanaugh/jgnash).
When a user makes an edit to an existing transaction, the expectation is
the prior selected ComboBox value is visible when the list is displayed,
otherwise
> This pull request fixes JDK-8129123. This bug also effects Windows and Linux
> platforms.
> Also, I believe JDK-8196037 is a duplicate of this issue.
>
> I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and
> Windows 10.
>
> Thanks!
Craig Cavana
ualFlowTestUtils.getVirtualFlow(comboBox);
> return virtualFlow;
> }
>
> Have a look at the tests in test.xx.controls to understand how to
> setup the test context. And have fun :)
>
> Zitat von Craig Cavanaugh :
>
> > I am trying to create a manual unit t
le-path $FX_LIB --add-modules javafx.controls
> ButtonMnemonicPositionTest.java
> $ java --module-path $FX_LIB --add-modules javafx.controls
> ButtonMnemonicPositionTest
>
> Hope this helps.
>
> We can discuss further on your PR.
>
> Regards,
> Ajit
>
>
I am trying to create a manual unit test for RFR: 8129123 and I'm using the
existing ButtonMnemonicPositionTest.java as a template to make sure
everything is working correctly.
I'm using an Ubuntu 18.04.4 build environment using the default 11.0.6
openjdk.
openjfx is successfully compiling and
On Thu, 2 Apr 2020 22:20:18 GMT, Kevin Rushforth wrote:
> Can you please provide a unit test? One that fails before your fix and passes
> after your fix.
I can provide a manual test the next couple of days that demonstrates it before
and after, but I'm not sure how to
create an automated unit
This pull request fixes JDK-8129123. This bug also effects Windows and Linux
platforms.
Also, I believe JDK-8196037 is a duplicate of this issue.
I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and Windows
10.
Thanks!
-
Commit messages:
- Merge branch
16 matches
Mail list logo
