WIP version with PI compile (Re: A WIP for JDK-8238080 for review/discussion (Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

There is a new WIP at which adds a compile PI (process instruction) for turning on and off script compilation if the script engine implements the Compilable interface. By default compilation is off (no compilation), such that one needs to add a compile

Re: A WIP for JDK-8238080 for review/discussion (Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

Yes, I agree that enough time has gone by. Go ahead with your proposal. I would wait a bit to create the CSR until the review is far enough along to know which direction we intend to go. Unless there is a real concern about possible regressions if scripts are compiled by default, I think

Re: A WIP for JDK-8238080 for review/discussion (Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

Hi there, as there was probably enough time that has passed by I would intend to create a CSR in the next days with the PR as per Kevin's suggestion. (For the case that this feature should not be active by default, the CSR will suggest to define a new "compile" PI in the form (default, if no

Re: A WIP for JDK-8238080 for review/discussion (Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

Hi Kevin, On 03.04.2020 01:21, Kevin Rushforth wrote: > I see that you updated the PR and sent it for review. > > Before we formally review it in the PR, let's finish the discussion as to > whether this is a useful > feature, and if so, what form this feature should take. > > From my point of

Re: Question ad CSR (Re: A WIP for JDK-8238080 for review/discussion (Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

Regarding the CSR, that's usually done after the enhancement is agreed upon in principle, and the review is far enough along that you are ready to write up the spec changes, new API, and/or new interfaces. Since you don't have direct JBS access you will need a sponsor to do that part for you,

Question ad CSR (Re: A WIP for JDK-8238080 for review/discussion (Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

Hi Kevin, thank you for your feedback and actions! Ad "please create a CSR request and add link to it in JDK-8238080": preliminarily researching [CSR FAQ] (https://wiki.openjdk.java.net/display/csr/CSR+FAQs) the question "Q: How do I create a CSR ?" gets answered with: > "A: _Do not directly

Re: A WIP for JDK-8238080 for review/discussion (Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

Hi Rony, I see that you updated the PR and sent it for review. Before we formally review it in the PR, let's finish the discussion as to whether this is a useful feature, and if so, what form this feature should take. From my point of view, this does seem like a useful feature. Would other

Re: A WIP for JDK-8238080 for review/discussion (Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

After merging master, applying some fixes and changing the title to reflect the change from WIP to a pull request I would kindly request a review of this pull request! Here the URL: , title changed to: "8238080: FXMLLoader: if script engines implement

A WIP for JDK-8238080 for review/discussion (Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

Here is a WIP [1] implementation of [2]. The WIP is based on [3], which is currently in review, and has an appropriate test unit going with it as well, please review. There should be no compatibility issue with this implementation. Discussion: another solution could be to not compile by

Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

On 24.01.2020 16:26, Kevin Rushforth wrote: > Thank you for filing this enhancement request. As an enhancement it should be > discussed on this > list before proceeding with a pull request (although a "WIP" or Draft PR can > be used to illustrate > the concept). Sure, will do after creating an

Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

Thank you for filing this enhancement request. As an enhancement it should be discussed on this list before proceeding with a pull request (although a "WIP" or Draft PR can be used to illustrate the concept). For my part, this seems like a reasonable enhancement, as long as there are no

"Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

Just filed a RFE with the following information: * Component: o JavaFX * Subcomponent: o fxml: JavaFX FXML * Synopsis: o "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts" * Descriptions: o "FXMLLoader is able to execute scripts