Re: [External] : Re: Consistent baseline layout algorithm

2021-04-16 Thread Michael Strauß
I've created a small sample app (a screenshot is available in the GitHub PR discussion at https://github.com/openjdk/jfx/pull/433), and it seems to me that, while understanding the intricacies of isTextBaseline and isPrefBaseline might be a bit tricky, from an application developer's perspective

Re: [External] : Re: Consistent baseline layout algorithm

2021-04-16 Thread Kevin Rushforth
Good, since these are the sort of behavioral changes we almost always avoid. That change in the default behavior likely would not have been approved. As for the rest, I'll need some time to fully understand the impact of the proposed behavior for propagating isTextBaseline up the tree, and

Re: [External] : Re: Consistent baseline layout algorithm

2021-04-16 Thread Michael Strauß
That's true, and it also seems like outside of synthetic tests, the benefit from this optimization diminishes in larger scene graphs. So I will revert this change. Am Fr., 16. Apr. 2021 um 16:28 Uhr schrieb Scott Palmer : > > “ I've changed the default alignment for > Label to TOP_LEFT (the

Re: [External] : Re: Consistent baseline layout algorithm

2021-04-16 Thread Scott Palmer
“ I've changed the default alignment for Label to TOP_LEFT (the default alignment of the base class Labeled is CENTER_LEFT).” How can you do that without breaking things? Even though it may be uncommon to set minHeight or prefHeight, that isn’t the point. It still breaks existing code. Scott

Re: [External] : Re: Consistent baseline layout algorithm

2021-04-15 Thread Michael Strauß
I've learned a few new things while working on the proposed new layout algorithm, and added a few new APIs: 1. A central concept of the new algorithm was the notion of a text-baseline node, indicated by Node::isTextBaseline(). I've come to realize that this property should percolate upwards in

Re: [External] : Re: Consistent baseline layout algorithm

2021-04-02 Thread Scott Palmer
I haven’t done much in terms of custom controls, but I do see this issue a lot in my primary application. It would be nice to have it fixed as the layout looks rather sloppy without it. Any time I see the layout “correct” itself when I interact with a control or tweak the size of a window it

Re: [External] : Re: Consistent baseline layout algorithm

2021-04-02 Thread Kevin Rushforth
Circling back to this: Do any JavaFX application developers on this list have any thoughts? I think this is a good idea, and it seems worth moving this forward, but it will require a fair bit of effort. I'd like to hear buy-in from other developers -- particularly those who develop or use