Re: [Rev 01] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-26 Thread Robert Lichtenberger
On Fri, 24 Jan 2020 15:41:20 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java > line 1994: > >> 1993: private ListChangeListener childListener = new >>

Re: [Rev 01] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-24 Thread Kevin Rushforth
On Fri, 24 Jan 2020 15:43:25 GMT, Robert Lichtenberger wrote: >> Test simulates a single mouse-released event. >> Fix simply guards against the null case. > > The pull request has been updated with 1 additional commit. This is a simple enough change that 1 reviewer will suffice -- @arapte

Re: [Rev 01] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-23 Thread Robert Lichtenberger
> Test simulates a single mouse-released event. > Fix simply guards against the null case. The pull request has been updated with 1 additional commit. - Added commits: - 30290116: 8237372: NullPointerException in TabPaneSkin.stopDrag Changes: - all:

Re: [Rev 01] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-23 Thread Robert Lichtenberger
On Wed, 22 Jan 2020 08:01:49 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java > line 2216: > >> 2215: // Animate tab header being dragged to its final