Re: [Rev 01] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-26 Thread Kevin Rushforth
On Thu, 26 Mar 2020 08:33:29 GMT, Johan Vos wrote: >> Like this? >> >> I think all C builds are covered. Gstreamer seems to have a Makefile with >> the flags. Not sure about libxml and libxlst >> inside javafx.web. > > I think it's better to split the flags between CFLAGS and CPPFLAGS (as is

Re: [Rev 01] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-26 Thread Johan Vos
On Wed, 25 Mar 2020 00:40:01 GMT, Thiago Milczarek Sayao wrote: >> The problem is that gcc, for whatever reason, started issuing a (useless) >> warning if you pass the >> `-Werror=implicit-function-declaration` option to gcc for C++ files. I don't >> like the solution of removing that flag >>

Re: [Rev 01] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-24 Thread Thiago Milczarek Sayao
On Tue, 24 Mar 2020 11:45:28 GMT, Kevin Rushforth wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The incremental >> webrev excludes the unrelated changes brought in by the merge/rebase. The >> pull request contains five

Re: [Rev 01] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-24 Thread Thiago Milczarek Sayao
> Simple fix to remove annoying warnings. Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last