Yes, that is an important clarification of the new policy. Thanks.
-- Kevin
On 6/12/2018 1:55 PM, Phil Race wrote:
One other point .. something I mentioned off line to Kevin but he did
not so far bring up here,
is that when counting the number of reviewers on a fix, we must
require at least o
One other point .. something I mentioned off line to Kevin but he did
not so far bring up here,
is that when counting the number of reviewers on a fix, we must require
at least one Reviewer,
with a capital "R", but to make up the total of 2 reviewers, it is
sufficient to have one other person
wh
On Thu, May 31, 2018 at 11:25 PM Kevin Rushforth
wrote:
>
>
> On 5/24/2018 9:31 AM, Nir Lisker wrote:
> > Thanks for the detailed plan Kevin,
> >
>
> ...
> >
> > Can you give the guidelines by which a lead reviews / approves one of
> > the above?
>
> Ultimately it will be a judgment call. I can't
On 5/24/2018 9:31 AM, Nir Lisker wrote:
Thanks for the detailed plan Kevin,
I will provide an initial list of reviewers to the registrar based
on past contributions, and also recognizing Committers who have
become experts in their area.
It will be a good idea to list the reviewe
r, via email, send a message with subject or body 'help' to
>> > openjfx-dev-requ...@openjdk.java.net
>> >
>> > You can reach the person managing the list at
>> > openjfx-dev-ow...@openjdk.java.net
>> >
>> > When replyin
Phil pointed out one glaring typo in the summary and also a couple
things in the details that could be clarified.
The short version of the proposal is:
...
2. Revised code review policies for different types of changes:
simple, low-impact fixes (1 Reviewer); higher-impact fixes (2
Reviewers +
Thanks for the detailed plan Kevin,
I will provide an initial list of reviewers to the registrar based on past
> contributions, and also recognizing Committers who have become experts in
> their area.
It will be a good idea to list the reviewers/experts (names and mail)
according to their field,
ev-requ...@openjdk.java.net
> >
> > You can reach the person managing the list at
> > openjfx-dev-ow...@openjdk.java.net
> >
> > When replying, please edit your Subject line so it i
; openjfx-dev-ow...@openjdk.java.net
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of openjfx-dev digest..."
>
>
> Today's Topics:
>
>1. OpenJFX code review policies, etc. (Kevin Rushforth)
>
>
&
To: OpenJFX Developers
As I mentioned in a message last week [1] I would like to restart the
discussion we started a few months ago [2] around making it easier to
contribute code to OpenJFX. To this end, I like to make some concrete
proposals around code review / API review policies.
Before
10 matches
Mail list logo
