Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v9]

2022-05-28 Thread Ambarish Rapte
On Fri, 27 May 2022 16:47:04 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >> 2.

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v9]

2022-05-27 Thread Kevin Rushforth
On Fri, 27 May 2022 16:47:04 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >> 2.

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v9]

2022-05-27 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its Eve

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v8]

2022-05-27 Thread Jay Bhaskar
On Fri, 27 May 2022 15:42:09 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change for unregisterDomWindow function and code cleanup > > modules/javafx.web/src/main/native/Source/WebCore/bindin

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v8]

2022-05-27 Thread Kevin Rushforth
On Fri, 27 May 2022 12:13:43 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >> 2.

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v7]

2022-05-27 Thread Jay Bhaskar
On Thu, 26 May 2022 17:00:46 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding space for map include > > modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v8]

2022-05-27 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its Eve

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v7]

2022-05-26 Thread Kevin Rushforth
On Thu, 26 May 2022 07:26:38 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >> 2.

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v7]

2022-05-26 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its Eve

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v6]

2022-05-26 Thread danielpeintner
On Thu, 26 May 2022 07:08:59 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >> 2.

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v6]

2022-05-26 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its Eve

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v5]

2022-05-25 Thread Jay Bhaskar
On Wed, 25 May 2022 14:57:13 GMT, Ambarish Rapte wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments applied > > modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.cpp >

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v5]

2022-05-25 Thread Jay Bhaskar
On Wed, 25 May 2022 12:45:59 GMT, Ambarish Rapte wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments applied > > modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.cpp >

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

2022-05-25 Thread Kevin Rushforth
On Tue, 24 May 2022 15:20:01 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding JGObject in plave of raw jni object > > modules/javafx.web/src/test/java/test/javafx/scene/web/EventListenerLe

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

2022-05-25 Thread Kevin Rushforth
On Sun, 22 May 2022 14:06:41 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >> 2.

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v5]

2022-05-25 Thread Kevin Rushforth
On Wed, 25 May 2022 10:10:08 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >> 2.

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v5]

2022-05-25 Thread Ambarish Rapte
On Wed, 25 May 2022 10:10:08 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >> 2.

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v5]

2022-05-25 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its Eve

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

2022-05-24 Thread Jay Bhaskar
On Tue, 24 May 2022 14:54:19 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding JGObject in plave of raw jni object > > modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventL

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

2022-05-24 Thread Kevin Rushforth
On Sun, 22 May 2022 14:06:41 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >> 2.

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

2022-05-22 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its Eve

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v2]

2022-05-22 Thread Jay Bhaskar
On Thu, 19 May 2022 21:45:00 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Platform.exit() , removing code block, as it is causing other test fail > > modules/javafx.web/src/main/native/Source

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v2]

2022-05-22 Thread Jay Bhaskar
On Thu, 19 May 2022 21:34:54 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Platform.exit() , removing code block, as it is causing other test fail > > modules/javafx.web/src/main/native/Source

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v3]

2022-05-22 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its Eve

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v2]

2022-05-20 Thread Kevin Rushforth
On Thu, 19 May 2022 22:01:31 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Platform.exit() , removing code block, as it is causing other test fail > > modules/javafx.web/src/test/java/test/jav

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v2]

2022-05-19 Thread Kevin Rushforth
On Thu, 19 May 2022 15:57:46 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >> 2.

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v2]

2022-05-19 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its Eve

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v2]

2022-05-19 Thread Jay Bhaskar
On Thu, 19 May 2022 15:22:08 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Platform.exit() , removing code block, as it is causing other test fail > > modules/javafx.web/src/test/java/test/jav

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener

2022-05-19 Thread Kevin Rushforth
On Thu, 19 May 2022 13:13:01 GMT, Jay Bhaskar wrote: > This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When

RFR: 8088420: JavaFX WebView memory leak via EventListener

2022-05-19 Thread Jay Bhaskar
This PR is new implementation of JavaEvent listener memory management. Issue [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) 1. Calling remove event listener does not free jni global references. 2. When WebView goes out of scope (disposed from app) , its Event Listeners