Re: [Closed] RFR: 8193286: IntegerSpinnerFactory does not wrap value correctly

2020-04-22 Thread Ajit Ghaisas
On Mon, 13 Apr 2020 06:59:08 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8193286 > > Root Cause : > Incorrect implementation. > Current implementation of int wrapValue(int,int,int) in Spinner.java works > well if min is 0. > Hence this implementation works with L

Re: RFR: 8193286: IntegerSpinnerFactory does not wrap value correctly

2020-04-22 Thread Ajit Ghaisas
On Wed, 22 Apr 2020 09:06:09 GMT, Jeanette Winzenburg wrote: >> I checked and there is a case that (mostly) works today that will break with >> your proposed fix. I left a couple inline >> comments. >> I wonder if it is better to wait and fix it completely in >> [JDK-8242553](https://bugs.openj

Re: RFR: 8193286: IntegerSpinnerFactory does not wrap value correctly

2020-04-22 Thread Jeanette Winzenburg
On Tue, 21 Apr 2020 23:34:07 GMT, Kevin Rushforth wrote: > > I wonder if it is better to wait and fix it completely in > [JDK-8242553](https://bugs.openjdk.java.net/browse/JDK-8242553). good idea - do it correctly once and for all :) - PR: https://git.openjdk.java.net/jfx/pull/174

Re: RFR: 8193286: IntegerSpinnerFactory does not wrap value correctly

2020-04-21 Thread Kevin Rushforth
On Mon, 13 Apr 2020 06:59:08 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8193286 > > Root Cause : > Incorrect implementation. > Current implementation of int wrapValue(int,int,int) in Spinner.java works > well if min is 0. > Hence this implementation works with L

Re: RFR: 8193286: IntegerSpinnerFactory does not wrap value correctly

2020-04-16 Thread Ajit Ghaisas
On Wed, 15 Apr 2020 23:18:46 GMT, Kevin Rushforth wrote: >> Issue : https://bugs.openjdk.java.net/browse/JDK-8193286 >> >> Root Cause : >> Incorrect implementation. >> Current implementation of int wrapValue(int,int,int) in Spinner.java works >> well if min is 0. >> Hence this implementation wo

Re: RFR: 8193286: IntegerSpinnerFactory does not wrap value correctly

2020-04-15 Thread Kevin Rushforth
On Mon, 13 Apr 2020 06:59:08 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8193286 > > Root Cause : > Incorrect implementation. > Current implementation of int wrapValue(int,int,int) in Spinner.java works > well if min is 0. > Hence this implementation works with L

RFR: 8193286: IntegerSpinnerFactory does not wrap value correctly

2020-04-13 Thread Ajit Ghaisas
Issue : https://bugs.openjdk.java.net/browse/JDK-8193286 Root Cause : Incorrect implementation. Current implementation of int wrapValue(int,int,int) in Spinner.java works well if min is 0. Hence this implementation works with ListSpinnerValueFactory, but fails with IntegerSpinnerValueFactory. F