On Thu, 9 Apr 2020 09:58:27 GMT, Jesper Skov
wrote:
> Make the two ways of associating a ToggleButton with a ToggleGroup interact
> correctly.
>
> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
This pull request has now been integrated.
Changeset: 3130fc80
Author:Jesper
On Sun, 19 Apr 2020 09:51:07 GMT, Jesper Skov
wrote:
>> Make the two ways of associating a ToggleButton with a ToggleGroup interact
>> correctly.
>>
>> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
>
> Jesper Skov has updated the pull request incrementally with three additional
On Sun, 19 Apr 2020 09:51:07 GMT, Jesper Skov
wrote:
>> Make the two ways of associating a ToggleButton with a ToggleGroup interact
>> correctly.
>>
>> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
>
> Jesper Skov has updated the pull request incrementally with three additional
On Thu, 23 Apr 2020 07:55:06 GMT, Jesper Skov
wrote:
>> Ah, well. Ended with the same VM crash when building webkit myself.
>>
>> So I am kinda stuck. Suggestions?
>
> I have found out that my :web:test failed because I did not have the
> media libs properly installed.
>
> So the changes in
On Sun, 19 Apr 2020 13:50:18 GMT, Jesper Skov
wrote:
>> Uh, the exception is (as the comment note suggests) from using a prebuilt
>> webkit.
>> I will try a locally built one now.
>
> Ah, well. Ended with the same VM crash when building webkit myself.
>
> So I am kinda stuck. Suggestions?
I
On Sun, 19 Apr 2020 09:34:00 GMT, Jesper Skov
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/ToggleButton.java
>> line 196:
>>
>>> 195: private ObjectProperty toggleGroup;
>>> 196: @Override
>>> 197: public final void setToggleGroup(ToggleGroup value) {
>>
On Sun, 19 Apr 2020 12:44:23 GMT, Jesper Skov
wrote:
>> I have failed getting web:tests to work.
>> Both with java 11.0.7 and 14.0.0 (adoptajdk 14.0.1 not ready yet), I get the
>> error below.
>>
>> And that is with both a locally built webkit, and the one from
>>
On Sun, 19 Apr 2020 12:42:09 GMT, Jesper Skov
wrote:
>> @kevinrushforth I tested by:
>> `
>> bash ./gradlew clean all test -x :web:test
>> `
>> I assumed that would do it.
>> But I see use of ToggleButton in javafx.web, so that was clearly a faulty
>> assumption.
>>
>> I will try to get
On Sun, 19 Apr 2020 09:56:27 GMT, Jesper Skov
wrote:
>> The fix looks correct to me. Have you run all tests to ensure no regressions?
>>
>> I left a couple inline comments.
>
> @kevinrushforth I tested by:
> `
> bash ./gradlew clean all test -x :web:test
> `
> I assumed that would do it.
> But
On Sat, 18 Apr 2020 16:04:34 GMT, Kevin Rushforth wrote:
>> Jesper Skov has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Fail instead of print message
>> - addedToggles list is final
>> - Leave unrelated file alone
>
> The fix
> Make the two ways of associating a ToggleButton with a ToggleGroup interact
> correctly.
>
> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
Jesper Skov has updated the pull request incrementally with three additional
commits since the last revision:
- Fail instead of print
On Sat, 18 Apr 2020 15:50:55 GMT, Kevin Rushforth wrote:
>> Make the two ways of associating a ToggleButton with a ToggleGroup interact
>> correctly.
>>
>> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
>
>
On Thu, 9 Apr 2020 09:58:27 GMT, Jesper Skov
wrote:
> Make the two ways of associating a ToggleButton with a ToggleGroup interact
> correctly.
>
> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
The fix looks correct to me. Have you run all tests to ensure no regressions?
I left
On Thu, 9 Apr 2020 10:00:49 GMT, Jesper Skov
wrote:
>> Make the two ways of associating a ToggleButton with a ToggleGroup interact
>> correctly.
>>
>> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
>
> /signed
@arapte can you also review?
-
PR:
On Thu, 9 Apr 2020 09:58:27 GMT, Jesper Skov
wrote:
> Make the two ways of associating a ToggleButton with a ToggleGroup interact
> correctly.
>
> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
/signed
-
PR: https://git.openjdk.java.net/jfx/pull/167
Make the two ways of associating a ToggleButton with a ToggleGroup interact
correctly.
This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
-
Commit messages:
- 8198402: Fix ToggleButton leak in ToggleGroup
Changes: https://git.openjdk.java.net/jfx/pull/167/files
Webrev:
16 matches
Mail list logo
