On Thu, 17 Sep 2020 06:35:16 GMT, Arun Joseph wrote:
>> The fix works when the shape is displayed initially on the screen, but fails
>> when we scroll the image off-screen and
>> then, back. To see the issue, you need to either rotate the gradient
>> transform (by 90 degrees) or use a circle (a
On Thu, 17 Sep 2020 06:29:36 GMT, Arun Joseph wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updates as per review comments
>
> The fix works when the shape is displayed initially on the screen, but fails
>
On Mon, 14 Sep 2020 13:47:28 GMT, Bhawesh Choudhary
wrote:
>> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
>> in WebKit was not implemented, so masking
>> doesn't take place at all while rendering SVGRect. to fix this issue add
>> implementation of function clipT
On Fri, 11 Sep 2020 00:13:48 GMT, Kevin Rushforth wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added unit test for strokes
>
> modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismCon
On Fri, 11 Sep 2020 00:10:29 GMT, Kevin Rushforth wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added unit test for strokes
>
> modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismCon
On Fri, 11 Sep 2020 06:48:35 GMT, Bhawesh Choudhary
wrote:
>> This question is still outstanding. It seems like the call to `setCTM` is
>> either needed before all of the `setGradient`
>> calls or none of them. Can you comment?
>
> i believe setCTM call is needed for none of them. it is a worka
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
> in WebKit was not implemented, so masking
> doesn't take place at all while rendering SVGRect. to fix this issue add
> implementation of function clipToImageBuffer()
> in GraphicsContextJava.cpp and send clip image to
On Fri, 11 Sep 2020 00:29:53 GMT, Kevin Rushforth wrote:
>> modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp
>> line 235:
>>
>>> 233: } else {
>>> 234: if (m_state.fillGradient) {
>>> 235: setCTM(m_state.transform);
>>
>>
On Fri, 7 Aug 2020 14:54:14 GMT, Kevin Rushforth wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed RenderSVGResourceMasker changes and added fix for HIDPI mask
>> rendering
>
> modules/javafx.web/src/ma
On Tue, 8 Sep 2020 09:56:06 GMT, Bhawesh Choudhary
wrote:
>> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
>> in WebKit was not implemented, so masking
>> doesn't take place at all while rendering SVGRect. to fix this issue add
>> implementation of function clipTo
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
> in WebKit was not implemented, so masking
> doesn't take place at all while rendering SVGRect. to fix this issue add
> implementation of function clipToImageBuffer()
> in GraphicsContextJava.cpp and send clip image to
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
> in WebKit was not implemented, so masking
> doesn't take place at all while rendering SVGRect. to fix this issue add
> implementation of function clipToImageBuffer()
> in GraphicsContextJava.cpp and send clip image to
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
> in WebKit was not implemented, so masking
> doesn't take place at all while rendering SVGRect. to fix this issue add
> implementation of function clipToImageBuffer()
> in GraphicsContextJava.cpp and send clip image to
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
> in WebKit was not implemented, so masking
> doesn't take place at all while rendering SVGRect. to fix this issue add
> implementation of function clipToImageBuffer()
> in GraphicsContextJava.cpp and send clip image to
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
> in WebKit was not implemented, so masking
> doesn't take place at all while rendering SVGRect. to fix this issue add
> implementation of function clipToImageBuffer()
> in GraphicsContextJava.cpp and send clip image to
On Tue, 28 Jul 2020 17:52:50 GMT, Bhawesh Choudhary
wrote:
>> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
>> in WebKit was not implemented, so masking
>> doesn't take place at all while rendering SVGRect. to fix this issue add
>> implementation of function clipT
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
> in WebKit was not implemented, so masking
> doesn't take place at all while rendering SVGRect. to fix this issue add
> implementation of function clipToImageBuffer()
> in GraphicsContextJava.cpp and send clip image to
On Fri, 24 Jul 2020 12:10:00 GMT, Arun Joseph wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> HiDPI printing and Rendering fix
>
> modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGResou
On Tue, 21 Jul 2020 21:50:39 GMT, Bhawesh Choudhary
wrote:
>> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
>> in WebKit was not implemented, so masking
>> doesn't take place at all while rendering SVGRect. to fix this issue add
>> implementation of function clipT
On Fri, 12 Jun 2020 22:01:47 GMT, Kevin Rushforth wrote:
>> The code looks good (with a couple minor formatting issues).
>>
>> All of the onscreen testing I did looks good on Windows. I'd like to test
>> it on Mac as well.
>>
>> There is an issue with printing in the case of Hi-DPI scaling, w
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
> in WebKit was not implemented, so masking
> doesn't take place at all while rendering SVGRect. to fix this issue add
> implementation of function clipToImageBuffer()
> in GraphicsContextJava.cpp and send clip image to
On Thu, 11 Jun 2020 20:47:12 GMT, Kevin Rushforth wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed unnecessery Ceil Functions
>
> The code looks good (with a couple minor formatting issues).
>
> All of
On Tue, 19 May 2020 10:13:44 GMT, Bhawesh Choudhary
wrote:
>> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
>> in WebKit was not implemented, so masking
>> doesn't take place at all while rendering SVGRect. to fix this issue add
>> implementation of function clipT
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
> in WebKit was not implemented, so masking
> doesn't take place at all while rendering SVGRect. to fix this issue add
> implementation of function clipToImageBuffer()
> in GraphicsContextJava.cpp and send clip image to
On Mon, 18 May 2020 08:00:38 GMT, Bhawesh Choudhary
wrote:
>> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
>> in WebKit was not implemented, so masking
>> doesn't take place at all while rendering SVGRect. to fix this issue add
>> implementation of function clipT
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
> in WebKit was not implemented, so masking
> doesn't take place at all while rendering SVGRect. to fix this issue add
> implementation of function clipToImageBuffer()
> in GraphicsContextJava.cpp and send clip image to
On Sun, 10 May 2020 20:49:07 GMT, Bhawesh Choudhary
wrote:
>> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
>> in WebKit was not implemented, so masking
>> doesn't take place at all while rendering SVGRect. to fix this issue add
>> implementation of function clipT
On Fri, 8 May 2020 23:37:51 GMT, Kevin Rushforth wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved Printing drawing path to non MaskTextureGraphics interface
>
> modules/javafx.web/src/main/java/com/sun/ja
On Fri, 8 May 2020 23:25:18 GMT, Kevin Rushforth wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved Printing drawing path to non MaskTextureGraphics interface
>
> modules/javafx.web/src/main/java/com/sun/ja
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
> in WebKit was not implemented, so masking
> doesn't take place at all while rendering SVGRect. to fix this issue add
> implementation of function clipToImageBuffer()
> in GraphicsContextJava.cpp and send clip image to
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
> in WebKit was not implemented, so masking
> doesn't take place at all while rendering SVGRect. to fix this issue add
> implementation of function clipToImageBuffer()
> in GraphicsContextJava.cpp and send clip image to
On Thu, 7 May 2020 09:19:28 GMT, Bhawesh Choudhary
wrote:
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
> in WebKit was not implemented, so masking
> doesn't take place at all while rendering SVGRect. to fix this issue add
> implementation of function clipToImag
Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp in
WebKit was not implemented, so masking
doesn't take place at all while rendering SVGRect. to fix this issue add
implementation of function clipToImageBuffer()
in GraphicsContextJava.cpp and send clip image to WCGraphic
33 matches
Mail list logo
