Re: [Integrated] RFR: 8232589: Remove CoreAudio Utility Classes

2020-01-07 Thread Alexander Matveev
Changeset: c9519b6e Author:Alexander Matveev Date: 2020-01-07 22:14:22 + URL: https://git.openjdk.java.net/jfx/commit/c9519b6e 8232589: Remove CoreAudio Utility Classes Reviewed-by: kcr, jvos ! modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/gst-plugins-good/gs

Re: RFR: 8232589: Remove CoreAudio Utility Classes

2020-01-06 Thread Johan Vos
On Wed, 18 Dec 2019 01:04:42 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8232589 > > - Removed CoreAudio Utility classes. > - Spectrum which was depended on CoreAudio Utility classes for doing > computations will now run GStreamer spectrum element to do spectrum. E

Re: RFR: 8232589: Remove CoreAudio Utility Classes

2020-01-06 Thread Kevin Rushforth
On Wed, 18 Dec 2019 01:04:42 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8232589 > > - Removed CoreAudio Utility classes. > - Spectrum which was depended on CoreAudio Utility classes for doing > computations will now run GStreamer spectrum element to do spectrum. E

Re: RFR: 8232589: Remove CoreAudio Utility Classes

2020-01-06 Thread Kevin Rushforth
On Mon, 6 Jan 2020 23:36:50 GMT, Alexander Matveev wrote: >> modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.cpp >> line 422: >> >>> 421: mEQBufferA = (double*)calloc(mEQBufferSize, >>> sizeof(double)); >>> 422: mEQBufferB = (double*)cal

Re: RFR: 8232589: Remove CoreAudio Utility Classes

2020-01-06 Thread Kevin Rushforth
On Mon, 6 Jan 2020 23:21:32 GMT, Alexander Matveev wrote: >> true, as spectrum->bps_user has #if defined (GSTREAMER_LITE) && defined >> (OSX) around its definition. >> >> Even apart from that, it would make more sense and bring it at the same >> level as line 738 > > No need for GSTREAMER_LIT

Re: RFR: 8232589: Remove CoreAudio Utility Classes

2020-01-06 Thread Alexander Matveev
On Fri, 20 Dec 2019 22:24:36 GMT, Kevin Rushforth wrote: >> https://bugs.openjdk.java.net/browse/JDK-8232589 >> >> - Removed CoreAudio Utility classes. >> - Spectrum which was depended on CoreAudio Utility classes for doing >> computations will now run GStreamer spectrum element to do spectrum.

Re: RFR: 8232589: Remove CoreAudio Utility Classes

2020-01-06 Thread Alexander Matveev
On Wed, 1 Jan 2020 19:16:33 GMT, Johan Vos wrote: >> modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/gst-plugins-good/gst/spectrum/gstspectrum.c >> line 915: >> >>> 914: bpf = GST_AUDIO_FILTER_BPF (spectrum); >>> 915: #ifdef OSX >>> 916: if (spectrum->bps_user != 0 && spectrum

Re: RFR: 8232589: Remove CoreAudio Utility Classes

2020-01-01 Thread Johan Vos
On Fri, 20 Dec 2019 22:19:27 GMT, Kevin Rushforth wrote: >> https://bugs.openjdk.java.net/browse/JDK-8232589 >> >> - Removed CoreAudio Utility classes. >> - Spectrum which was depended on CoreAudio Utility classes for doing >> computations will now run GStreamer spectrum element to do spectrum.

Re: RFR: 8232589: Remove CoreAudio Utility Classes

2019-12-20 Thread Kevin Rushforth
On Wed, 18 Dec 2019 01:04:42 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8232589 > > - Removed CoreAudio Utility classes. > - Spectrum which was depended on CoreAudio Utility classes for doing > computations will now run GStreamer spectrum element to do spectrum. E

RFR: 8232589: Remove CoreAudio Utility Classes

2019-12-17 Thread Alexander Matveev
https://bugs.openjdk.java.net/browse/JDK-8232589 - Removed CoreAudio Utility classes. - Spectrum which was depended on CoreAudio Utility classes for doing computations will now run GStreamer spectrum element to do spectrum. Element will be run without pipeline and will be used as utility library