Re: [Integrated] RFR: 8236448: Remove unused and repair broken Android/Dalvik code

2020-01-08 Thread Johan Vos
Changeset: e6587ff0 Author:Johan Vos Date: 2020-01-08 14:20:28 + URL: https://git.openjdk.java.net/jfx/commit/e6587ff0 8236448: Remove unused and repair broken Android/Dalvik code Reviewed-by: kcr ! buildSrc/android.gradle !

Re: [Rev 02] RFR: 8236448: Remove unused and repair broken Android/Dalvik code

2020-01-07 Thread Kevin Rushforth
On Tue, 7 Jan 2020 22:59:25 GMT, Johan Vos wrote: >> This allows to build the JavaFX jars and native libraries for Android devices > > The pull request has been updated with 1 additional commit. Looks good. - Marked as reviewed by kcr (Lead). PR:

Re: [Rev 02] RFR: 8236448: Remove unused and repair broken Android/Dalvik code

2020-01-07 Thread Johan Vos
> This allows to build the JavaFX jars and native libraries for Android devices The pull request has been updated with 1 additional commit. - Added commits: - 13699670: process reviewer comments Changes: - all: https://git.openjdk.java.net/jfx/pull/75/files - new:

Re: [Rev 01] RFR: 8236448: Remove unused and repair broken Android/Dalvik code

2020-01-07 Thread Johan Vos
> This allows to build the JavaFX jars and native libraries for Android devices The pull request has been updated with 1 additional commit. - Added commits: - f8321fd0: copy (android) resources into directory where they are picked up by the jar task Changes: - all:

Re: RFR: 8236448: Remove unused and repair broken Android/Dalvik code

2020-01-03 Thread Kevin Rushforth
On Mon, 30 Dec 2019 11:05:55 GMT, Johan Vos wrote: > This allows to build the JavaFX jars and native libraries for Android devices I did a test build on Linux since there were changes to the shared Monocle classes. I didn't really look at the `android.gradle` changes or the new

RFR: 8236448: Remove unused and repair broken Android/Dalvik code

2019-12-30 Thread Johan Vos
This allows to build the JavaFX jars and native libraries for Android devices - Commits: - 504a2440: fix trailing whitespace - 97a3f14f: Fix for #8236448 Changes: https://git.openjdk.java.net/jfx/pull/75/files Webrev: https://webrevs.openjdk.java.net/jfx/75/webrev.00 Issue: