Changeset: 5a0e71b8
Author:Robert Lichtenberger
Committer: Ambarish Rapte
Date: 2020-01-29 06:25:21 +
URL: https://git.openjdk.java.net/jfx/commit/5a0e71b8
8237372: NullPointerException in TabPaneSkin.stopDrag
Reviewed-by: arapte
!
On Tue, 28 Jan 2020 16:04:59 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> The fix looks good to me.
> Verified that the new test fails before and passes after fix and observed no
> test failures.
I don't have any additional comment, so this is
On Tue, 28 Jan 2020 18:04:54 GMT, Robert Lichtenberger
wrote:
>> Test simulates a single mouse-released event.
>> Fix simply guards against the null case.
>
> The pull request has been updated with 1 additional commit.
The fix looks good to me.
Verified that the new test fails before and
> Test simulates a single mouse-released event.
> Fix simply guards against the null case.
The pull request has been updated with 1 additional commit.
-
Added commits:
- 39a61821: 8237372: NullPointerException in TabPaneSkin.stopDrag
Changes:
- all:
On Tue, 28 Jan 2020 12:38:32 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TabPaneTest.java
> line 57:
>
>> 56: import javafx.scene.input.KeyEvent;
>> 57: import
On Tue, 28 Jan 2020 12:39:20 GMT, Robert Lichtenberger
wrote:
>> Test simulates a single mouse-released event.
>> Fix simply guards against the null case.
>
> The pull request has been updated with 1 additional commit.
Fix looks good, suggested minor changes in test.
On Fri, 24 Jan 2020 15:41:20 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java
> line 1994:
>
>> 1993: private ListChangeListener childListener = new
>>
> Test simulates a single mouse-released event.
> Fix simply guards against the null case.
The pull request has been updated with 1 additional commit.
-
Added commits:
- a54a5306: 8237372: NullPointerException in TabPaneSkin.stopDrag
Changes:
- all:
On Fri, 24 Jan 2020 15:43:25 GMT, Robert Lichtenberger
wrote:
>> Test simulates a single mouse-released event.
>> Fix simply guards against the null case.
>
> The pull request has been updated with 1 additional commit.
This is a simple enough change that 1 reviewer will suffice -- @arapte
> Test simulates a single mouse-released event.
> Fix simply guards against the null case.
The pull request has been updated with 1 additional commit.
-
Added commits:
- 30290116: 8237372: NullPointerException in TabPaneSkin.stopDrag
Changes:
- all:
On Wed, 22 Jan 2020 08:01:49 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java
> line 2216:
>
>> 2215: // Animate tab header being dragged to its final
On Mon, 20 Jan 2020 10:00:55 GMT, Robert Lichtenberger
wrote:
> Test simulates a single mouse-released event.
> Fix simply guards against the null case.
The scenario mentioned in
[JDK-8237372](https://bugs.openjdk.java.net/browse/JDK-8237372) seems valid
scenario. However I am not sure if
On Mon, 20 Jan 2020 10:00:55 GMT, Robert Lichtenberger
wrote:
> Test simulates a single mouse-released event.
> Fix simply guards against the null case.
@arapte - can you review this?
The only question I have is whether is is expected that `dragTabHeader` can be
null. If we understand why it
Test simulates a single mouse-released event.
Fix simply guards against the null case.
-
Commits:
- 923a63b2: 8237372: NullPointerException in TabPaneSkin.stopDrag
Changes: https://git.openjdk.java.net/jfx/pull/89/files
Webrev: https://webrevs.openjdk.java.net/jfx/89/webrev.00
14 matches
Mail list logo
