Re: RFR: 8244297: memory leak test utility [v5]

2020-10-16 Thread Florian Kirmaier
On Thu, 8 Oct 2020 07:57:17 GMT, Ambarish Rapte wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8244297 >> Fixing some wrong imports > > I have reviewed only in perspective of Java coding guidelines. I

Re: RFR: 8244297: memory leak test utility [v5]

2020-10-08 Thread Ambarish Rapte
On Wed, 30 Sep 2020 11:46:24 GMT, Florian Kirmaier wrote: >> It's based on the discussion of my previous PR: >> https://github.com/openjdk/jfx/pull/71 >> >> I Added test utility class copied from JMemoryBuddy and used it to simplify >> 4 of the existing unit tests. >> >> It's a direct copy

Re: RFR: 8244297: memory leak test utility [v5]

2020-09-30 Thread Florian Kirmaier
> It's based on the discussion of my previous PR: > https://github.com/openjdk/jfx/pull/71 > > I Added test utility class copied from JMemoryBuddy and used it to simplify 4 > of the existing unit tests. > > It's a direct copy of my project >