Re: RFR: 8255713: JavaFX build should discover Visual Studio compiler on system

2021-03-17 Thread Johan Vos
On Tue, 16 Mar 2021 16:30:51 GMT, Kevin Rushforth wrote: > We currently hard-code the default version of Visual Studio in both > `win.gradle` and `.github/workflows/submit.yml`. This hard-coding of the > specific version of MSVC is fragile, particularly for GitHub action builds. > The last tim

Re: RFR: 8255713: JavaFX build should discover Visual Studio compiler on system

2021-03-17 Thread Ambarish Rapte
On Tue, 16 Mar 2021 16:30:51 GMT, Kevin Rushforth wrote: > We currently hard-code the default version of Visual Studio in both > `win.gradle` and `.github/workflows/submit.yml`. This hard-coding of the > specific version of MSVC is fragile, particularly for GitHub action builds. > The last tim

Re: RFR: 8255713: JavaFX build should discover Visual Studio compiler on system

2021-03-16 Thread Johan Vos
On Tue, 16 Mar 2021 16:30:51 GMT, Kevin Rushforth wrote: > We currently hard-code the default version of Visual Studio in both > `win.gradle` and `.github/workflows/submit.yml`. This hard-coding of the > specific version of MSVC is fragile, particularly for GitHub action builds. > The last tim

RFR: 8255713: JavaFX build should discover Visual Studio compiler on system

2021-03-16 Thread Kevin Rushforth
We currently hard-code the default version of Visual Studio in both `win.gradle` and `.github/workflows/submit.yml`. This hard-coding of the specific version of MSVC is fragile, particularly for GitHub action builds. The last time Microsoft changed the environment, our Windows builds started fai