Re: RFR: 8260163: IrresponsiveScriptTest.testInfiniteLoopInScript unit test fails on Windows [v2]

2021-02-01 Thread Kevin Rushforth
On Mon, 1 Feb 2021 16:52:10 GMT, Arun Joseph wrote: >> Windows uses `WorkQueueGeneric` instead of `WorkQueueWin` from WebKit 610.2 >> onwards. In `WorkQueueWin`, `WorkQueue::dispatchAfter()` had a 20 ms >> `slopAdjustment` as the timer (called from `::SetTimer`) sometimes fire a >> few ms

Re: RFR: 8260163: IrresponsiveScriptTest.testInfiniteLoopInScript unit test fails on Windows [v2]

2021-02-01 Thread Arun Joseph
On Mon, 1 Feb 2021 16:55:50 GMT, Kevin Rushforth wrote: >> Arun Joseph has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update comment > > modules/javafx.web/src/main/native/Source/WTF/wtf/generic/WorkQueueGeneric.cpp > line 85: > >>

Re: RFR: 8260163: IrresponsiveScriptTest.testInfiniteLoopInScript unit test fails on Windows [v2]

2021-02-01 Thread Kevin Rushforth
On Mon, 1 Feb 2021 16:52:10 GMT, Arun Joseph wrote: >> Windows uses `WorkQueueGeneric` instead of `WorkQueueWin` from WebKit 610.2 >> onwards. In `WorkQueueWin`, `WorkQueue::dispatchAfter()` had a 20 ms >> `slopAdjustment` as the timer (called from `::SetTimer`) sometimes fire a >> few ms

Re: RFR: 8260163: IrresponsiveScriptTest.testInfiniteLoopInScript unit test fails on Windows [v2]

2021-02-01 Thread Arun Joseph
> Windows uses `WorkQueueGeneric` instead of `WorkQueueWin` from WebKit 610.2 > onwards. In `WorkQueueWin`, `WorkQueue::dispatchAfter()` had a 20 ms > `slopAdjustment` as the timer (called from `::SetTimer`) sometimes fire a few > ms early. The same is not present in `WorkQueueGeneric` and

Re: RFR: 8260163: IrresponsiveScriptTest.testInfiniteLoopInScript unit test fails on Windows

2021-02-01 Thread Kevin Rushforth
On Mon, 1 Feb 2021 03:31:10 GMT, Arun Joseph wrote: > Windows uses `WorkQueueGeneric` instead of `WorkQueueWin` from WebKit 610.2 > onwards. In `WorkQueueWin`, `WorkQueue::dispatchAfter()` had a 20 ms > `slopAdjustment` as the timer (called from `::SetTimer`) sometimes fire a few > ms early.

RFR: 8260163: IrresponsiveScriptTest.testInfiniteLoopInScript unit test fails on Windows

2021-01-31 Thread Arun Joseph
Windows uses `WorkQueueGeneric` instead of `WorkQueueWin` from WebKit 610.2 onwards. In `WorkQueueWin`, `WorkQueue::dispatchAfter()` had a 20 ms `slopAdjustment` as the timer (called from `::SetTimer`) sometimes fire a few ms early. The same is not present in `WorkQueueGeneric` and needs to be