Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v2]

2021-04-04 Thread John Neffenger
On Sat, 3 Apr 2021 01:49:47 GMT, John Neffenger wrote: >>> Silly question, is the difference with Windows just the nature of the >>> native support on each platform (Unix based vs Windows) and libraries used >>> as part of that? >> >> That's a good question. I'm hoping the answer is no. So

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v2]

2021-04-02 Thread John Neffenger
On Fri, 2 Apr 2021 17:45:38 GMT, John Neffenger wrote: >> Media makefiles look fine. > >> Silly question, is the difference with Windows just the nature of the native >> support on each platform (Unix based vs Windows) and libraries used as part >> of that? > > That's a good question. I'm

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v2]

2021-04-02 Thread John Neffenger
On Thu, 1 Apr 2021 23:21:55 GMT, Alexander Matveev wrote: >> John Neffenger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Include media shared libraries for Windows >> >> Enable reproducible builds of the native media shared

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v2]

2021-04-01 Thread Alexander Matveev
On Thu, 1 Apr 2021 19:14:37 GMT, John Neffenger wrote: >> This pull request allows for reproducible builds of JavaFX on Linux, macOS, >> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For >> example, the following commands create a reproducible build: >> >> $ export

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v2]

2021-04-01 Thread John Neffenger
> This pull request allows for reproducible builds of JavaFX on Linux, macOS, > and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For > example, the following commands create a reproducible build: > > $ export SOURCE_DATE_EPOCH=$(git log -1 --pretty=%ct) > $ bash gradlew sdk