On Fri, 24 Sep 2021 20:45:23 GMT, Kevin Rushforth wrote:
> As mentioned in JBS, any new third-party libraries require prior third-party
> license approval. And we will need to work with you on sponsoring this (as
> you can't contribute any third-party code under the OCA).
>
> Speaking of
On Thu, 11 Nov 2021 15:11:32 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Readd junit declaration in allprojects and set junit version to 4.13.2
>
> build.gradle line 1953:
>
>> 1951:
On Sat, 25 Sep 2021 13:55:15 GMT, John Hendrikx wrote:
>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
>> still work. Also added a single JUnit 5 tests, and confirmed it works.
>>
>> I've updated the Eclipse project file for the base module only.
>
> John
On Mon, 15 Nov 2021 16:42:04 GMT, Michael Strauß wrote:
> One comment about adding new JUnit 5 tests and migrating existing tests. I
> think there could be value in organizing the tests such that all of the JUnit
> 5 tests are grouped, rather than mixing tests in the same directory such that
On Thu, 11 Nov 2021 15:18:25 GMT, Kevin Rushforth wrote:
> I left a few comments on the dependencies. Will review / test the PR later.
>
> One comment about adding new JUnit 5 tests and migrating existing tests. I
> think there could be value in organizing the tests such that all of the JUnit
On Fri, 24 Sep 2021 21:17:14 GMT, John Hendrikx wrote:
>> I will try block this and get back to you.
>
> Hamcrest could be blocked, tests still run.
As it turns out, `hamcrest` does not need to be blocked, so you can restore it
if it is easier. I'll leave it up to you.
-
PR:
On Sat, 25 Sep 2021 13:55:15 GMT, John Hendrikx wrote:
>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
>> still work. Also added a single JUnit 5 tests, and confirmed it works.
>>
>> I've updated the Eclipse project file for the base module only.
>
> John
On Sat, 25 Sep 2021 13:55:15 GMT, John Hendrikx wrote:
>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
>> still work. Also added a single JUnit 5 tests, and confirmed it works.
>>
>> I've updated the Eclipse project file for the base module only.
>
> John
On Sat, 25 Sep 2021 13:55:15 GMT, John Hendrikx wrote:
>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
>> still work. Also added a single JUnit 5 tests, and confirmed it works.
>>
>> I've updated the Eclipse project file for the base module only.
>
> John