Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v8]

2022-03-10 Thread John Hendrikx
On Thu, 10 Mar 2022 14:21:15 GMT, Nir Lisker wrote: >> modules/javafx.base/src/test/java/test/javafx/beans/value/ObservableValueFluentBindingsTest.java >> line 648: >> >>> 646: >>> 647: /** >>> 648: * Ensures nothing has been observed. >> >> "Ensures nothing has been observed since

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v8]

2022-03-10 Thread Nir Lisker
On Tue, 8 Mar 2022 21:03:12 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix wrong test values > >

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v8]

2022-03-09 Thread John Hendrikx
On Tue, 8 Mar 2022 20:57:53 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix wrong test values > >

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v8]

2022-03-09 Thread John Hendrikx
On Tue, 8 Mar 2022 21:10:46 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix wrong test values > >

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v8]

2022-03-08 Thread Nir Lisker
On Thu, 27 Jan 2022 21:49:07 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v8]

2022-01-27 Thread John Hendrikx
> This is an implementation of the proposal in > https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker > (@nlisker) have been working on. It's a complete implementation including > good test coverage. > > This was based on https://github.com/openjdk/jfx/pull/434 but with a