[jfx17u] RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

2021-12-07 Thread Johan Vos
Clean backport (18->17) for 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver - Commit messages: - 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver Changes: https://git.openjdk.java.net/jfx17u/pull/24/files Webrev:

[jfx11u] RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

2021-12-07 Thread Johan Vos
Clean backport for 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver - Commit messages: - 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver Changes: https://git.openjdk.java.net/jfx11u/pull/65/files Webrev:

Re: RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver [v2]

2021-11-30 Thread Ambarish Rapte
On Tue, 30 Nov 2021 12:18:50 GMT, Jose Pereda wrote: >> This PR enables intersection observer support for WebKit, and includes a >> system test. > > Jose Pereda has updated the pull request incrementally with one additional > commit since the last revision: > > Address feedback Marked as

Re: RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver [v2]

2021-11-30 Thread Kevin Rushforth
On Tue, 30 Nov 2021 12:18:50 GMT, Jose Pereda wrote: >> This PR enables intersection observer support for WebKit, and includes a >> system test. > > Jose Pereda has updated the pull request incrementally with one additional > commit since the last revision: > > Address feedback Marked as

Re: RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

2021-11-30 Thread Jose Pereda
On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote: > This PR enables intersection observer support for WebKit, and includes a > system test. No problem, I just pushed the minor change. - PR: https://git.openjdk.java.net/jfx/pull/664

Re: RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver [v2]

2021-11-30 Thread Jose Pereda
> This PR enables intersection observer support for WebKit, and includes a > system test. Jose Pereda has updated the pull request incrementally with one additional commit since the last revision: Address feedback - Changes: - all:

Re: RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

2021-11-30 Thread Kevin Rushforth
On Tue, 30 Nov 2021 06:40:16 GMT, Ambarish Rapte wrote: > Looks good to me. Shall re-approve when PR is updated as per Kevin's > suggestion. @jperedadnr My suggestion was optional, so you can either integrate it as-is or make the (minor) change and we'll re-approve. - PR:

Re: RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

2021-11-29 Thread Ambarish Rapte
On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote: > This PR enables intersection observer support for WebKit, and includes a > system test. Looks good to me. Shall re-approve when PR is updated as per Kevin's suggestion. - Marked as reviewed by arapte (Reviewer). PR:

Re: RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

2021-11-29 Thread Kevin Rushforth
On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote: > This PR enables intersection observer support for WebKit, and includes a > system test. @aghaisas or @arapte can one of you be the second reviewer? - PR: https://git.openjdk.java.net/jfx/pull/664

Re: RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

2021-11-24 Thread Kevin Rushforth
On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote: > This PR enables intersection observer support for WebKit, and includes a > system test. Looks good. I've tested this on all platforms and confirm that it fixes the issue with no regressions that I can see. I also confirm that the new test

Re: RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

2021-11-23 Thread Jose Pereda
On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote: > This PR enables intersection observer support for WebKit, and includes a > system test. Worth pointing out that [JDK-8273558](https://bugs.openjdk.java.net/browse/JDK-8273558) gets fixed with this PR. - PR:

Re: RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

2021-11-10 Thread Kevin Rushforth
On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote: > This PR enables intersection observer support for WebKit, and includes a > system test. This looks like a reasonable thing to do. - PR: https://git.openjdk.java.net/jfx/pull/664

RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

2021-11-10 Thread Jose Pereda
This PR enables intersection observer support for WebKit, and includes a system test. - Commit messages: - Include html file - Enable intersection observer support, including system test Changes: https://git.openjdk.java.net/jfx/pull/664/files Webrev: