Clean backport (18->17) for 8276847: JSException: ReferenceError: Can't find
variable: IntersectionObserver
-
Commit messages:
- 8276847: JSException: ReferenceError: Can't find variable:
IntersectionObserver
Changes: https://git.openjdk.java.net/jfx17u/pull/24/files
Webrev:
Clean backport for 8276847: JSException: ReferenceError: Can't find variable:
IntersectionObserver
-
Commit messages:
- 8276847: JSException: ReferenceError: Can't find variable:
IntersectionObserver
Changes: https://git.openjdk.java.net/jfx11u/pull/65/files
Webrev:
On Tue, 30 Nov 2021 12:18:50 GMT, Jose Pereda wrote:
>> This PR enables intersection observer support for WebKit, and includes a
>> system test.
>
> Jose Pereda has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Address feedback
Marked as
On Tue, 30 Nov 2021 12:18:50 GMT, Jose Pereda wrote:
>> This PR enables intersection observer support for WebKit, and includes a
>> system test.
>
> Jose Pereda has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Address feedback
Marked as
On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote:
> This PR enables intersection observer support for WebKit, and includes a
> system test.
No problem, I just pushed the minor change.
-
PR: https://git.openjdk.java.net/jfx/pull/664
> This PR enables intersection observer support for WebKit, and includes a
> system test.
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Address feedback
-
Changes:
- all:
On Tue, 30 Nov 2021 06:40:16 GMT, Ambarish Rapte wrote:
> Looks good to me. Shall re-approve when PR is updated as per Kevin's
> suggestion.
@jperedadnr My suggestion was optional, so you can either integrate it as-is or
make the (minor) change and we'll re-approve.
-
PR:
On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote:
> This PR enables intersection observer support for WebKit, and includes a
> system test.
Looks good to me. Shall re-approve when PR is updated as per Kevin's suggestion.
-
Marked as reviewed by arapte (Reviewer).
PR:
On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote:
> This PR enables intersection observer support for WebKit, and includes a
> system test.
@aghaisas or @arapte can one of you be the second reviewer?
-
PR: https://git.openjdk.java.net/jfx/pull/664
On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote:
> This PR enables intersection observer support for WebKit, and includes a
> system test.
Looks good. I've tested this on all platforms and confirm that it fixes the
issue with no regressions that I can see. I also confirm that the new test
On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote:
> This PR enables intersection observer support for WebKit, and includes a
> system test.
Worth pointing out that
[JDK-8273558](https://bugs.openjdk.java.net/browse/JDK-8273558) gets fixed with
this PR.
-
PR:
On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote:
> This PR enables intersection observer support for WebKit, and includes a
> system test.
This looks like a reasonable thing to do.
-
PR: https://git.openjdk.java.net/jfx/pull/664
This PR enables intersection observer support for WebKit, and includes a system
test.
-
Commit messages:
- Include html file
- Enable intersection observer support, including system test
Changes: https://git.openjdk.java.net/jfx/pull/664/files
Webrev:
13 matches
Mail list logo