Re: [12] RFR : JDK-8203884 : Update libjpeg to version 9c

2018-10-01 Thread Phil Race
I filed two bugs JDK-8211362: Restrict export of libjpeg symbols from libjavafx_iio.so JDK-8211363: Use platform version of libjpeg on Linux -phil On 10/01/2018 02:01 PM, Phil Race wrote: On 10/1/2018 1:55 PM, Phil Race wrote: The JDK has shipped a libjpeg since, well, forever. PS .. we now

Re: [12] RFR : JDK-8203884 : Update libjpeg to version 9c

2018-10-01 Thread Phil Race
On 10/1/2018 1:55 PM, Phil Race wrote: The JDK has shipped a libjpeg since, well, forever. PS .. we now call it libjavajpeg.so but that is recent (JDK 9). -phil. For a long time it did export all the symbols, but what is now probably an even longer time, it has exported only the JNI entry

Re: [12] RFR : JDK-8203884 : Update libjpeg to version 9c

2018-10-01 Thread Phil Race
The JDK has shipped a libjpeg since, well, forever. For a long time it did export all the symbols, but what is now probably an even longer time, it has exported only the JNI entry points. We can do the same here. The JDK approach used to be tediously maintained mapfiles. But recently it was

Re: [12] RFR : JDK-8203884 : Update libjpeg to version 9c

2018-10-01 Thread Johan Vos
Unrelated to the patch, I wonder if there is a better way to include this functionality. If we bundle an application that uses JavaFX but also includes a native library that links with libjpeg, there will be issues due to duplicate symbols (this happens for example when running deeplearning4j on