RE: Fix proposal: boolean flag & public API for JDK-8204060 - Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage()

2018-10-23 Thread Ambarish Rapte
ge- From: Kevin Rushforth Sent: Tuesday, October 16, 2018 4:25 AM To: Dan Howard mailto:spro...@videotron.ca"spro...@videotron.ca>; Ambarish Rapte mailto:ambarish.ra...@oracle.com"ambarish.ra...@oracle.com>; HYPERLINK "mailto:openjfx-dev@openjdk.java.net"openjfx-dev

Re: Fix proposal: boolean flag & public API for JDK-8204060 - Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage()

2018-10-17 Thread Nir Lisker
; * > ************* > > Regards, > Ambarish > > -----Original Message- > From: Kevin Rushforth > Sent: Tuesday, October 16, 2018 4:25 AM > To: Dan Howard ; Ambarish Rapte < > ambarish.ra...@oracle.com&

Re: Fix proposal: boolean flag & public API for JDK-8204060 - Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage()

2018-10-15 Thread Kevin Rushforth
Yes, it should be "isImageSmoothing", thanks for catching this! This looks good to me to other than that. The only other comment is that when you write the docs, make sure you indicate that this applies to drawImage calls, both in the docs of the new setImageSmooth method, and in the docs of

Re: Fix proposal: boolean flag & public API for JDK-8204060 - Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage()

2018-10-15 Thread Nir Lisker
> > public void setImageSmoothing(boolean imageSmoothing) {} to enable or > disable smoothing. A bit of forward thinking here. Will there always be only 2 ways of doing smoothing: "on" or "off"? If there will be different algorithms for smoothing, will they be set separately by

Re: Fix proposal: boolean flag & public API for JDK-8204060 - Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage()

2018-10-15 Thread Dan Howard
Shouldn't it be "is" rather than "get" for boolean?  Other than that, sounds good! On 10/15/2018 3:29 PM, Ambarish Rapte wrote: Hi All, This email is for discussion regarding the fix https://bugs.openjdk.java.net/browse/JDK-8204060 . Issue: Images drawn using javafx.scene.canvas