Re: RFR: 8181775: JavaFX WebView does not calculate border-radius properly [v4]

2020-08-09 Thread Arun Joseph
On Thu, 23 Jul 2020 09:43:36 GMT, Bhawesh Choudhary wrote: >> root cause of issue is prism's fillRoundedRect() API doesn't allow rendering >> of rounded corner rectangle if four >> corners have different radii. but same can be achieved via Path. to fix the >> issue, in GraphicsContextJava.cpp

Re: RFR: 8181775: JavaFX WebView does not calculate border-radius properly [v4]

2020-08-07 Thread Kevin Rushforth
On Thu, 23 Jul 2020 09:43:36 GMT, Bhawesh Choudhary wrote: >> root cause of issue is prism's fillRoundedRect() API doesn't allow rendering >> of rounded corner rectangle if four >> corners have different radii. but same can be achieved via Path. to fix the >> issue, in GraphicsContextJava.cpp

Re: RFR: 8181775: JavaFX WebView does not calculate border-radius properly [v4]

2020-07-23 Thread Kevin Rushforth
On Fri, 15 May 2020 17:33:10 GMT, Kevin Rushforth wrote: >> Bhawesh Choudhary has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now >> contains four commits: >> - Merge branch 'master' into 8181775 >> - Removed wildcard import statement >> - F

Re: RFR: 8181775: JavaFX WebView does not calculate border-radius properly [v4]

2020-07-23 Thread Bhawesh Choudhary
> root cause of issue is prism's fillRoundedRect() API doesn't allow rendering > of rounded corner rectangle if four > corners have different radii. but same can be achieved via Path. to fix the > issue, in GraphicsContextJava.cpp while > rendering fillRoundedRect, check if all four corners have

Re: RFR: 8181775: JavaFX WebView does not calculate border-radius properly [v3]

2020-07-22 Thread Bhawesh Choudhary
> root cause of issue is prism's fillRoundedRect() API doesn't allow rendering > of rounded corner rectangle if four > corners have different radii. but same can be achieved via Path. to fix the > issue, in GraphicsContextJava.cpp while > rendering fillRoundedRect, check if all four corners have

Re: RFR: 8181775: JavaFX WebView does not calculate border-radius properly

2020-05-15 Thread Kevin Rushforth
On Thu, 14 May 2020 08:15:19 GMT, Bhawesh Choudhary wrote: > root cause of issue is prism's fillRoundedRect() API doesn't allow rendering > of rounded corner rectangle if four > corners have different radii. but same can be achieved via Path. to fix the > issue, in GraphicsContextJava.cpp whil