On Fri, 26 Jun 2020 09:22:53 GMT, Ambarish Rapte wrote:
>> Issue:
>> In TreeTableView, in case of Multiple selection mode, if nested items are
>> selected, then TreeTableView does not
>> retain/update the selection correctly when the tree items are
>> permuted(either by `sort()` or by reorderin
On Fri, 26 Jun 2020 09:22:53 GMT, Ambarish Rapte wrote:
>> Issue:
>> In TreeTableView, in case of Multiple selection mode, if nested items are
>> selected, then TreeTableView does not
>> retain/update the selection correctly when the tree items are
>> permuted(either by `sort()` or by reorderin
On Thu, 25 Jun 2020 22:45:17 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comment corrections, adding new tests
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/T
On Thu, 25 Jun 2020 22:48:07 GMT, Kevin Rushforth wrote:
>
>
> The changes to the fix itself look fine. I have a question and minor comment
> on the test changes.
>
> As for the questions raised by @kleopatra as long as you plan to address them
> in the follow-up issue(s), that seems
> fine,
On Thu, 25 Jun 2020 22:44:18 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comment corrections, adding new tests
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/T
> Issue:
> In TreeTableView, in case of Multiple selection mode, if nested items are
> selected, then TreeTableView does not
> retain/update the selection correctly when the tree items are permuted(either
> by `sort()` or by reordering using
> `setAll()`). Cause:
>
> 1. For permutation, the cur
On Wed, 24 Jun 2020 11:02:53 GMT, Ambarish Rapte wrote:
>> Issue:
>> In TreeTableView, in case of Multiple selection mode, if nested items are
>> selected, then TreeTableView does not
>> retain/update the selection correctly when the tree items are
>> permuted(either by `sort()` or by reorderin
> Issue:
> In TreeTableView, in case of Multiple selection mode, if nested items are
> selected, then TreeTableView does not
> retain/update the selection correctly when the tree items are permuted(either
> by `sort()` or by reordering using
> `setAll()`). Cause:
>
> 1. For permutation, the cur
On Tue, 23 Jun 2020 13:09:44 GMT, Jeanette Winzenburg
wrote:
> While digging a bit (mainly around my [earlier
> concerns](https://github.com/openjdk/jfx/pull/244#issuecomment-638702570) -
> which still hold but could be discussed in
> a follow-up issue :)
Yes, We need to address these issues.
On Tue, 23 Jun 2020 10:02:17 GMT, Ajit Ghaisas wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove the un-required flag
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TreeTablePosition.java
>
On Tue, 23 Jun 2020 12:32:22 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableView.java
>> line 1856:
>>
>>> 1855: Callback, Boolean> sortPolicy =
>>> getSortPolicy();
>>> 1856: if (sortPolicy == null) return;
>>> 1857:
On Fri, 19 Jun 2020 23:04:51 GMT, Kevin Rushforth wrote:
>> Marked as reviewed by kcr (Lead).
>
> Pending a second reviewer.
>
> @aghaisas or @kleopatra can one of you review it?
confirmed test failures before and passing after the fix - impressive :)
While digging a bit (mainly around my [ear
On Tue, 23 Jun 2020 10:07:37 GMT, Ajit Ghaisas wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove the un-required flag
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableView.java
> line
On Wed, 17 Jun 2020 11:38:45 GMT, Ambarish Rapte wrote:
>> Issue:
>> In TreeTableView, in case of Multiple selection mode, if nested items are
>> selected, then TreeTableView does not
>> retain/update the selection correctly when the tree items are
>> permuted(either by `sort()` or by reorderin
On Wed, 17 Jun 2020 12:28:41 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove the un-required flag
>
> Marked as reviewed by kcr (Lead).
Pending a second reviewer.
@aghaisas or @kleop
On Wed, 17 Jun 2020 11:46:07 GMT, Ambarish Rapte wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java
>> line 472:
>>
>>> 471: countSelectedIndexChangeEvent++;
>>> 472: assertEquals(selectedItemBefore,
>>> treeTableView.getTre
On Wed, 17 Jun 2020 11:38:45 GMT, Ambarish Rapte wrote:
>> Issue:
>> In TreeTableView, in case of Multiple selection mode, if nested items are
>> selected, then TreeTableView does not
>> retain/update the selection correctly when the tree items are
>> permuted(either by `sort()` or by reorderin
On Tue, 2 Jun 2020 17:00:28 GMT, Ambarish Rapte wrote:
> Issue:
> In TreeTableView, in case of Multiple selection mode, if nested items are
> selected, then TreeTableView does not
> retain/update the selection correctly when the tree items are permuted(either
> by `sort()` or by reordering usin
On Tue, 2 Jun 2020 17:00:28 GMT, Ambarish Rapte wrote:
> Issue:
> In TreeTableView, in case of Multiple selection mode, if nested items are
> selected, then TreeTableView does not
> retain/update the selection correctly when the tree items are permuted(either
> by `sort()` or by reordering usin
19 matches
Mail list logo
