Re: RFR: 8228363 Fix shifts for ContextMenu shown on TOP/LEFT side

2020-02-10 Thread Abhinay Agarwal
ontextMenu? -- Abhinay From: openjfx-dev on behalf of Abhinay Agarwal Sent: Saturday, February 8, 2020 1:15 PM To: Kevin Rushforth ; openjfx-dev@openjdk.java.net Subject: Re: RFR: 8228363 Fix shifts for ContextMenu shown on TOP/LEFT side Hi Kevin, Yes, this is actually a pre-review mail

Re: RFR: 8228363 Fix shifts for ContextMenu shown on TOP/LEFT side

2020-02-07 Thread Abhinay Agarwal
enjfx-dev@openjdk.java.net Subject: Re: RFR: 8228363 Fix shifts for ContextMenu shown on TOP/LEFT side I presume this is a "pre" review before sending out an actual review (which the Skara tooling will do automatically when you generate a pull request)... My concern with this appr

Re: RFR: 8228363 Fix shifts for ContextMenu shown on TOP/LEFT side

2020-02-07 Thread Kevin Rushforth
I presume this is a "pre" review before sending out an actual review (which the Skara tooling will do automatically when you generate a pull request)... My concern with this approach is that it leaks what should be an implementation detail into a visible property of the control (and really, u