On Thu, 4 Nov 2021 17:15:45 GMT, Nir Lisker wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
> Nir Lisker has updated the
On Thu, 4 Nov 2021 17:15:45 GMT, Nir Lisker wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
> Nir Lisker has updated the
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
> Nir Lisker has updated the
> Replacements of more immutable collections.
>
> One thing I found was that the field `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
> if that's indeed the case.
Nir Lisker has updated the pull request incrementally with one additional
commit since
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
> Nir Lisker has updated the
On Wed, 27 Oct 2021 15:52:38 GMT, Nir Lisker wrote:
> @johanvos Can you comment on `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView`?
That is unused and can safely be deleted.
-
PR: https://git.openjdk.java.net/jfx/pull/627
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
> Nir Lisker has updated the
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
> Nir Lisker has updated the
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
> Nir Lisker has updated the
On Fri, 15 Oct 2021 16:23:10 GMT, Kevin Rushforth wrote:
> > Do you want to do something about `idMap` in
> > `com.sun.java.scene.web.WebViewHelper.WebView` that I pointed out in the PR?
>
> I missed that comment. Where do you see this field? I can't find it anywhere.
Oh, I see it now. It's
On Fri, 15 Oct 2021 15:04:00 GMT, Nir Lisker wrote:
> Do you want to do something about `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView` that I pointed out in the PR?
I missed that comment. Where do you see this field? I can't find it anywhere.
-
PR:
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
> Nir Lisker has updated the
> Replacements of more immutable collections.
>
> One thing I found was that the field `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
> if that's indeed the case.
Nir Lisker has updated the pull request incrementally with one additional
commit since
On Thu, 14 Oct 2021 23:50:10 GMT, Kevin Rushforth wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
>
On Tue, 21 Sep 2021 11:13:06 GMT, Nir Lisker wrote:
> Replacements of more immutable collections.
>
> One thing I found was that the field `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
> if that's indeed the case.
Marked as reviewed by kcr (Lead).
On Thu, 23 Sep 2021 18:03:37 GMT, Marius Hanl wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
>
On Thu, 23 Sep 2021 21:55:57 GMT, delvh
wrote:
>> We still build JavaFX with `--release 11` so applications using JavaFX can
>> run on JDK 11 or later. At some point we will bump the minimum version of
>> Java that is required, but until then we cannot use records or any other
>> feature
On Thu, 23 Sep 2021 12:43:20 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/font/WindowsFontMap.java
>> line 32:
>>
>>> 30: class WindowsFontMap {
>>> 31:
>>> 32: private static class FamilyDescription {
>>
>> Isn't that basically a `record` in
On Tue, 21 Sep 2021 11:13:06 GMT, Nir Lisker wrote:
> Replacements of more immutable collections.
>
> One thing I found was that the field `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
> if that's indeed the case.
On Tue, 21 Sep 2021 11:13:06 GMT, Nir Lisker wrote:
> Replacements of more immutable collections.
>
> One thing I found was that the field `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
> if that's indeed the case.
This is a pretty simple change,
On Wed, 22 Sep 2021 21:36:26 GMT, delvh
wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
>
On Tue, 21 Sep 2021 11:13:06 GMT, Nir Lisker wrote:
> Replacements of more immutable collections.
>
> One thing I found was that the field `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
> if that's indeed the case.
22 matches
Mail list logo
