Re: RFR: 8274274: Update JavaFX test framework to JUnit 5

2021-09-24 Thread Kevin Rushforth
On Fri, 24 Sep 2021 20:25:48 GMT, John Hendrikx wrote: > Sorry for the force push, forgot I already submitted it as a PR. That's OK. I deleted the couple of comments I had added relating to blocks that disappeared. - PR: https://git.openjdk.java.net/jfx/pull/633

Re: RFR: 8274274: Update JavaFX test framework to JUnit 5 [v2]

2021-09-24 Thread John Hendrikx
On Fri, 24 Sep 2021 20:31:14 GMT, Kevin Rushforth wrote: >> John Hendrikx has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. > > gradle/verification-metadata.xml l

Re: RFR: 8274274: Update JavaFX test framework to JUnit 5 [v2]

2021-09-24 Thread Kevin Rushforth
On Fri, 24 Sep 2021 20:41:19 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John Hendri

Re: RFR: 8274274: Update JavaFX test framework to JUnit 5

2021-09-24 Thread John Hendrikx
On Fri, 24 Sep 2021 20:05:01 GMT, John Hendrikx wrote: > I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests > still work. Also added a single JUnit 5 tests, and confirmed it works. > > I've updated the Eclipse project file for the base module only. Sorry for the forc

Re: RFR: 8274274: Update JavaFX test framework to JUnit 5 [v2]

2021-09-24 Thread John Hendrikx
> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests > still work. Also added a single JUnit 5 tests, and confirmed it works. > > I've updated the Eclipse project file for the base module only. John Hendrikx has refreshed the contents of this pull request, and previous