[9] Review request: JDK-8165522 Remove #ifndef USE_JLI_LAUNCH from native launcher

Chris, Please review the changes about removing native packager JNI code. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165522 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8165522/webrev.00/ --Victor

[9] Review request: JDK-8162923 Error: Unknown Argument thrown by javpackager when argument values are passed with multiple words with in quotation

Chris, Please review the changes about argument quotation for javapackager. JIRA: https://bugs.openjdk.java.net/browse/JDK-8162923 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8162923/webrev.00/ --Victor

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

Yes, we decide to punt on ImagePattern as there isn't a trivial way to find a reasonable background color for it. - Chien On 11/10/16, 10:22 AM, Jim Graham wrote: I guess we'll punt on ImagePattern? Other than that the fix looks fine... ...jim On 11/9/16 5:35 PM, Chien Yang

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

Not as trivial as the Gradient cases, true. +1 on the fix if we're happy with that limitation... ...jim On 11/10/16 3:34 PM, Chien Yang wrote: Yes, we decide to punt on ImagePattern as there isn't a trivial way to find a reasonable background color for it. - Chien

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

I have tested with different StageStyle and Fill combinations, and all seems to work well with the proposed fix. No more white flashing if the Scene.fill is set with a color(with/without alpha). - Chien On 11/10/16, 4:58 AM, Kevin Rushforth wrote: Hi Tom, This is a good question, and will

Re: Fwd: Re: Marlin-Renderer and JavaFX

Jim, > > I would think an effort to parallelize a single shape rasterization would > be much simpler in scope. Still outside the current JDK 9 timeline, but > definitely something that could help in future releases. I believe that > once we put the edges into the internal structures we could

Re: Marlin-Renderer and JavaFX

If Oracle are interested in it (and permit me to be part of the JavaFX community on a level playing field), I would be more than happy to! (Such as not having to wait for every post to be moderated for example). > On 10 Nov. 2016, at 21:56, Tobias Bley wrote: > > What about

Re: Marlin-Renderer and JavaFX

Started? I have a fully working prototype! And it's not just "parallelised" but it greatly improves the efficiency and utilisation of both the CPU (and cores) and the GPU(s). > On 10 Nov. 2016, at 18:35, Tobias Bley wrote: > > Do you have started any parallelization? > > > >>

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

Hi Tom, This is a good question, and will needs to be checked. If it is a problem, then one possibility would be to modify the fix to skip the call to setBackground if StageStyle == TRANSPARENT. -- Kevin Tom Schindl wrote: Hi, Might be dumb questions but Did you try that this doesn't

Re: Fwd: Re: Marlin-Renderer and JavaFX

Jim, 2016-11-10 0:39 GMT+01:00 Jim Graham : > Going forward perhaps we should refer to the version of Marlin in Java2D > as Marlin2D? > > Then Marlin is your original plug-in version that is still being worked on. > Marlin2D is what you integrated into OpenJDK/Java2D. >

Re: Fwd: Re: Marlin-Renderer and JavaFX

Jim, 2016-11-10 0:47 GMT+01:00 Jim Graham : > Hi Laurent, > > Great job on creating a very obvious minimal impact! That should help > streamline it through the approval process. > Thanks. > > Is MarlinProperties.isEnabled still used? (Searching patch file - no, I >

Re: Marlin-Renderer and JavaFX

Felix & Tobias, Could you please start another thread to discuss the parallelization (multi-threading) in JavaFX Graphics ? I am a bit lost as there is 13 messages since 12 hours on several topics (marlin, MT ...) so I would like closing this topic soon by answering MarlinFX questions and

Re: Marlin-Renderer and JavaFX

Hi, First results with DemoFX (run.sh -e sierpinski) to compare a simple path scene with HW pipeline (es2): - native pisces: 138 fps - open pisces: 150 fps - marlin fx: 300 fps But it is too simple to evaluate Marlin improvements: the more complex the shape is, the more performance you get

Re: Marlin-Renderer and JavaFX

What about performance benchmark? Did you already tried to benchmark your prototype with DemoFX from Chris Newsland? https://github.com/chriswhocodes/DemoFX > Am 10.11.2016 um 08:40 schrieb Felix Bembrick : > > Started?

Review request for JDK-8169270: Leverage new Java2D Marlin rasterizer for JavaFX

Jim & Kevin, Sorry to announce this code review in late, I thought JBS would have sent such email from the comment. Please review the marlin-FX webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8169270.0/ JBS: https://bugs.openjdk.java.net/browse/JDK-8169270 Reviewers: flar, kcr

review: fix old jar list in build.gradle

Kevin, would you review: https://bugs.openjdk.java.net/browse/JDK-8169552 diff is inside the bug. -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Optimised, high-performance, multi-threaded rendering pipeline

(Thanks to Kevin for lifting my "awaiting moderation" impasse). So, with all the recent discussions regarding the great contribution by Laurent Bourgès of MarlinFX, it was suggested that a separate thread be started to discuss parallelisation of the JavaFX rendering pipeline in general. As has

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

I guess we'll punt on ImagePattern? Other than that the fix looks fine... ...jim On 11/9/16 5:35 PM, Chien Yang wrote: Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev:

Re: Fwd: Re: Marlin-Renderer and JavaFX

Another thought on multi-threaded scan-line rasterization would be to pre-scan the node tree and pre-rasterize all shapes into masks before we run through and render them to the destination. Again, that would be outside the scope of 9, but it would be a change only to the rendering process (and

Re: JDK-8163078 ArrayIndexOutOfBounds is thrown in Parent.updateCachedBounds

Hi Daniel, I mentioned it, because we got similar exceptions in our application, which stalled our application completely We moved the add of the listeners around. Luckily we could move most of the code,which added or removed listeners, to the application startup code. So the problem went

[9] RfR: 8169289: JavaFX application in named module fails to launch if no main method

Please review the JavaFX changes needed for this issue: https://bugs.openjdk.java.net/browse/JDK-8169289 webrev: http://cr.openjdk.java.net/~ddehaven/8169289/openjfx-rt.0 For reference, the OpenJDK changes needed are here: http://cr.openjdk.java.net/~ddehaven/8169289/jdk.0/ These are being

RE: JDK-8163078 ArrayIndexOutOfBounds is thrown in Parent.updateCachedBounds

Hi Stefan, >From code review it seems that this is not the case. I'll ask my team mate to >check this programmatically just to make sure... Note that JDK-8163078 contains a code example which reproduces the exception but adds and removes listeners on the JavaFX thread. Kind regards, Daniel >

New JavaFX performance benchmark (DemoFX part III)

Hi all, Hope not too off-topic but I've just released the 3rd version of my JavaFX performance benchmark "DemoFX". This time it exercises the PixelWriter (of Canvas and WriteableImage), the spectral analyser (thanks for adding this!), and some 3D as well as drawing on the Canvas. It does use