Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

On Wed, 16 Oct 2019 15:29:05 GMT, Kevin Rushforth wrote: > On Wed, 16 Oct 2019 15:21:55 GMT, Arunprasad Rajkumar > wrote: > >> On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar >> wrote: >> >>> 8232158: [macOS] Fallback to command line tools if xcode is missing >>> >>>

Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

On Wed, 16 Oct 2019 15:21:55 GMT, Arunprasad Rajkumar wrote: > On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar > wrote: > >> 8232158: [macOS] Fallback to command line tools if xcode is missing >> >> >> >> Commits: >> - 063d2f38: JDK-8232158: [macOS] Fallback to

Re: RFR: 8211308: Support HTTP/2 in WebView

On Fri, 11 Oct 2019 11:21:08 GMT, Robin Westberg wrote: > On Fri, 11 Oct 2019 07:01:48 GMT, Arunprasad Rajkumar > wrote: > >> On Fri, 11 Oct 2019 06:44:09 GMT, Johan Vos wrote: >> >>> On Fri, 11 Oct 2019 06:18:38 GMT, Arunprasad Rajkumar >>> wrote: >>> On Fri, 11 Oct 2019 06:07:14

Re: RFR: 8211308: Support HTTP/2 in WebView

On Wed, 16 Oct 2019 18:10:00 GMT, Kevin Rushforth wrote: > On Wed, 16 Oct 2019 17:58:32 GMT, Arunprasad Rajkumar > wrote: > >> On Fri, 11 Oct 2019 11:21:08 GMT, Robin Westberg >> wrote: >> >>> On Fri, 11 Oct 2019 07:01:48 GMT, Arunprasad Rajkumar >>> wrote: >>> On Fri, 11 Oct 2019

Change Priority of JDK-8231513

I would like to ask whether it doesn't make sense to give this issue a little more attention than P4: https://bugs.openjdk.java.net/browse/JDK-8231513 Essentially, as Kevin Rushforth confirmed in the Ticket, any JavaFX application will trigger a warning on the latest stable macOS release that

Re: [Rev 01] RFR: WIP: 8211308: Support HTTP/2 in WebView

The pull request has been updated with additional changes. Added commits: - 1832c2db: Incorporate fixes provided by @kcr Changes: - all: https://git.openjdk.java.net/jfx/pull/14/files - new: https://git.openjdk.java.net/jfx/pull/14/files/1798a661..1832c2db Webrevs: -

Re: RFR: 8211308: Support HTTP/2 in WebView

On Wed, 16 Oct 2019 17:58:32 GMT, Arunprasad Rajkumar wrote: > On Fri, 11 Oct 2019 11:21:08 GMT, Robin Westberg > wrote: > >> On Fri, 11 Oct 2019 07:01:48 GMT, Arunprasad Rajkumar >> wrote: >> >>> On Fri, 11 Oct 2019 06:44:09 GMT, Johan Vos wrote: >>> On Fri, 11 Oct 2019 06:18:38

Re: Bug in TreeTableView rendering

Zitat von Sverre Moe : A comment on the JDK-8231644 issue was added by Jeanette Winzenburg https://bugs.openjdk.java.net/browse/JDK-8231644 hmm .. no testing done but: the data object looks pathological - it's always problematic to have nodes as data (even though technically possible).

Re: Bug in TreeTableView rendering

A comment on the JDK-8231644 issue was added by Jeanette Winzenburg https://bugs.openjdk.java.net/browse/JDK-8231644 > hmm .. no testing done but: the data object looks pathological - it's always problematic to have nodes as data (even though technically possible). That will explode with the

Re: [11][13] RFR: Request to backport October 2019 CPU changes

+1 On Tue, Oct 15, 2019 at 6:43 PM Kevin Rushforth wrote: > Hi Johan, > > I request approval to backport the changes from the just-released April > 2019 CPU to 11-dev and 13-dev. > > https://cr.openjdk.java.net/~kcr/cpu-1910-sync/11-dev/webrev/ >

RFR: 8207759: VK_ENTER not consumed by TextField when default Button exists

This is a fix for https://bugs.openjdk.java.net/browse/JDK-8207759 The issue is that default/cancel button on a scene are triggered even though a onKeyPressed handler for ENTER/CANCEL consumes the keyEvent. See the bug for details on both cause and fix. There are additional/changed tests to

RFR: 8232378: change JavaFX release version in 13-dev to 13.0.1

Please review http://cr.openjdk.java.net/~jvos/8232378/webrev.00/ which fixes https://bugs.openjdk.java.net/browse/JDK-8232378 Thanks, - Johan

RFR: 8232377: Change JavaFX release version in 11-dev to 11.0.5

Please review the webrev for bumpding the JavaFX release version for 11-dev to 11.0.5 [1], available at [ 2] Thanks, - Johan [1] https://bugs.openjdk.java.net/browse/JDK-8232377 [2] http://cr.openjdk.java.net/~jvos/8232377/webrev.00/

Re: RFR: 8232377: Change JavaFX release version in 11-dev to 11.0.5

+1 On 10/16/2019 7:24 AM, Johan Vos wrote: Please review the webrev for bumpding the JavaFX release version for 11-dev to 11.0.5 [1], available at [ 2] Thanks, - Johan [1] https://bugs.openjdk.java.net/browse/JDK-8232377 [2]

Re: RFR: 8207759: VK_ENTER not consumed by TextField when default Button exists

On Wed, 16 Oct 2019 13:07:45 GMT, Jeanette Winzenburg wrote: > This is a fix for https://bugs.openjdk.java.net/browse/JDK-8207759 > > The issue is that default/cancel button on a scene are triggered even though > a onKeyPressed handler for ENTER/CANCEL consumes the keyEvent. See the bug >

Re: [14] RFR: Request to sync October 2019 CPU changes into jfx

+1 On Tue, Oct 15, 2019 at 6:42 PM Kevin Rushforth wrote: > Johan and Phil, > > I request approval to sync changes from to the just-released October > 2019 CPU release into 'jfx'. Here is the aggregate set of changes for > the fixes: > >

Building OpenJFX on clean install of CentOS 7

Hi, I did a clean install of CentOS 7, updated, added the necessary tools and then cloned the repo and ran the default build. I get the following errors: /home/test00/Source/jfx/modules/javafx.graphics/src/main/native-glass/gtk/glass_general.cpp:598:1: error: unused parameter ‘event’

Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar wrote: > 8232158: [macOS] Fallback to command line tools if xcode is missing > > > > Commits: > - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode is > missing > > Changes:

Re: RFR: 8232378: change JavaFX release version in 13-dev to 13.0.1

+1 On 10/16/2019 7:42 AM, Johan Vos wrote: Please review http://cr.openjdk.java.net/~jvos/8232378/webrev.00/ which fixes https://bugs.openjdk.java.net/browse/JDK-8232378 Thanks, - Johan