Re: [Approved] RFR: 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene

2019-11-11 Thread Ajit Ghaisas
On Fri, 8 Nov 2019 10:32:58 GMT, Jeanette Winzenburg wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - fbdea3df: changed test to compile under oldish junit > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/20/files >

RFR: 8232063: Upgrade gradle to version 6.0

2019-11-11 Thread Kevin Rushforth
This PR upgrades the version of gradle used to build JavaFX to 6.0. In addition to keeping up to date, this will allow us to subsequently upgrade the boot JDK to JDK 13. This change does the following: 1. Use ivy `patternLayout ...` instead of `layout "pattern" ...` and specify no metadata

Re: RFR: 8232063: Upgrade gradle to version 6.0

2019-11-11 Thread Kevin Rushforth
On Mon, 11 Nov 2019 15:22:48 GMT, Kevin Rushforth wrote: > This PR upgrades the version of gradle used to build JavaFX to 6.0. In > addition to keeping up to date, this will allow us to subsequently upgrade > the boot JDK to JDK 13. > > This change does the following: > > 1. Use ivy

Re: RFR: 8233338: FX javadoc headings are out of sequence

2019-11-11 Thread Kevin Rushforth
On Mon, 11 Nov 2019 15:40:24 GMT, Kevin Rushforth wrote: > On Thu, 31 Oct 2019 19:40:25 GMT, Kevin Rushforth wrote: > >> As indicated in >> [JDK-828](https://bugs.openjdk.java.net/browse/JDK-828), this fixes >> all of our javadoc HTML headings to conform with the rule that all HTML

Re: RFR: 8233338: FX javadoc headings are out of sequence

2019-11-11 Thread Kevin Rushforth
On Thu, 31 Oct 2019 19:40:25 GMT, Kevin Rushforth wrote: > As indicated in > [JDK-828](https://bugs.openjdk.java.net/browse/JDK-828), this fixes > all of our javadoc HTML headings to conform with the rule that all HTML > heading tags in class documents must start with `` and be nested

Re: [Integrated] RFR: 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene

2019-11-11 Thread Ajit Ghaisas
Changeset: 94bcf3fc Author:Jeanette Winzenburg Committer: Ajit Ghaisas Date: 2019-11-12 04:21:17 + URL: https://git.openjdk.java.net/jfx/commit/94bcf3fc 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene Reviewed-by: aghaisas !