Re: [Rev 04] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

2020-03-17 Thread Ajit Ghaisas
On Mon, 16 Mar 2020 13:00:32 GMT, Jeanette Winzenburg wrote: >> Good catch!!! >> It definitely would have unintentional side effect of incorrect orientation >> in subsequent tests. >> I updated the test to restore the orientation at the end of the test. Also >> documented the same. > > hmm ...

Re: [Rev 07] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

2020-03-17 Thread Ajit Ghaisas
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480 > > Fix : Added the missed out RTL checks to the key mappings in > TableViewBehaviorBase class. > > Testing : Modified unit tests in TableViewKeyInputTest to take orientation as > a parameter. The Left/Right key press > tests have been mo

Re: [Rev 03] RFR: 8238954: Improve performance of tiled snapshot rendering

2020-03-17 Thread Ambarish Rapte
On Sat, 14 Mar 2020 13:14:51 GMT, Frederic Thevenet wrote: >> Issue JDK-8088198, where an exception would be thrown when trying to capture >> a snapshot whose final dimensions would be >> larger than the running platform's maximum supported texture size, was >> addressed in openjfx14. The fix,

Re: [Rev 02] RFR: 8238954: Improve performance of tiled snapshot rendering

2020-03-17 Thread Ambarish Rapte
On Sat, 14 Mar 2020 13:25:00 GMT, Frederic Thevenet wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java >> line 1600: >> >>> 1599: } >>> 1600: } >>> 1601: } >> >> The

Re: [Rev 06] RFR: 8236259: MemoryLeak in ProgressIndicator

2020-03-17 Thread Ambarish Rapte
On Fri, 13 Mar 2020 05:31:52 GMT, Ambarish Rapte wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8200224 >> removed create garbage > > Marked as reviewed by arapte (Reviewer). @FlorianKirmaier Please int

Re: [Rev 04] RFR: 8238954: Improve performance of tiled snapshot rendering

2020-03-17 Thread Frederic Thevenet
> Issue JDK-8088198, where an exception would be thrown when trying to capture > a snapshot whose final dimensions would be > larger than the running platform's maximum supported texture size, was > addressed in openjfx14. The fix, based around > the idea of capturing as many tiles of the maximum

sane default option values for Linux

2020-03-17 Thread Ty Young
Hi all, After many months of being unable to run my JavaFX application due to transitioning to the new Project Panama MemoryAccess API(for native C calling, of course), I've finally gotten things to semi-working order and able to tryout JavaFX 14... only to find out that JavaFX on Linux is s

Re: [Rev 04] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

2020-03-17 Thread Jeanette Winzenburg
On Thu, 12 Mar 2020 12:42:28 GMT, Jeanette Winzenburg wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> extra space removed > > sry for the spelling errors you inherited :) @aghaisas can't see your last response he

Re: [Rev 03] RFR: 8238954: Improve performance of tiled snapshot rendering

2020-03-17 Thread Nir Lisker
On Tue, 17 Mar 2020 11:01:55 GMT, Ambarish Rapte wrote: >> Frederic Thevenet has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed code style and typo following review. > > The PR looks good to me, Please revert the changes in import. N

Re: [Integrated] RFR: 8236259: MemoryLeak in ProgressIndicator

2020-03-17 Thread Ambarish Rapte
Changeset: b81cf32b Author:Florian Kirmaier Committer: Ambarish Rapte Date: 2020-03-17 13:44:41 + URL: https://git.openjdk.java.net/jfx/commit/b81cf32b 8236259: MemoryLeak in ProgressIndicator Reviewed-by: kcr, arapte ! modules/javafx.controls/src/main/java/javafx/scene/con

Re: [Rev 03] RFR: 8238954: Improve performance of tiled snapshot rendering

2020-03-17 Thread Frederic Thevenet
On Tue, 17 Mar 2020 13:28:57 GMT, Nir Lisker wrote: > > > Now that the tiling is done in the `QuantumRenderer` level, I'll bring back > [JDK-8189082](https://bugs.openjdk.java.net/browse/JDK-8189082). Can't this > tiling be used to fix that? It won't help with thing in their current state, as

Re: RFR: 8239107: Update libjpeg to version 9d

2020-03-17 Thread Arun Joseph
On Thu, 12 Mar 2020 10:43:37 GMT, Ambarish Rapte wrote: > Currently we use IJG libjpeg version 9c released on 14-Jan-2018 > We should update the libjpeg to latest version [9d](http://www.ijg.org/) > released on 12-Jan-2020 > > reference: https://jpegclub.org/reference/reference-sources/ Marked

Re: [Rev 03] RFR: 8238954: Improve performance of tiled snapshot rendering

2020-03-17 Thread Frederic Thevenet
On Tue, 17 Mar 2020 14:19:45 GMT, Frederic Thevenet wrote: >> Now that the tiling is done in the `QuantumRenderer` level, I'll bring back >> [JDK-8189082](https://bugs.openjdk.java.net/browse/JDK-8189082). Can't this >> tiling be used to fix that? > >> >> >> Now that the tiling is done in the

Bulk request to backport 21 fixes to 11-dev for 11.0.7

2020-03-17 Thread Kevin Rushforth
Hi Johan, We request approval to backport the following 21 fixes, which Guru and I prepared. Two of the 21 fixes, the GStreamer and Glib upgrades, were done as a single commit, so there will be a single changeset pushed for those two. By coincidence, that commit is the only one that didn't app

Re: [Integrated] RFR: 8239107: Update libjpeg to version 9d

2020-03-17 Thread Ambarish Rapte
Changeset: 90289a23 Author:Ambarish Rapte Date: 2020-03-18 05:57:46 + URL: https://git.openjdk.java.net/jfx/commit/90289a23 8239107: Update libjpeg to version 9d Reviewed-by: kcr, ajoseph ! modules/javafx.graphics/src/main/legal/jpeg_fx.md ! modules/javafx.graphics/src/main/n