Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-07-28 Thread Nir Lisker
On Thu, 23 Jul 2020 12:06:17 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now >> contains 11 commits: >> - Merge branch 'master' into 8217472_Add_attenuation_for_PointLight >> - Attenuation and

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-07-28 Thread Nir Lisker
On Fri, 24 Jul 2020 21:29:06 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now >> contains 11 commits: >> - Merge branch 'master' into 8217472_Add_attenuation_for_PointLight >> - Attenuation and

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-07-28 Thread Nir Lisker
On Fri, 24 Jul 2020 21:01:08 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now >> contains 11 commits: >> - Merge branch 'master' into 8217472_Add_attenuation_for_PointLight >> - Attenuation and

[jfx15] Integrated: 8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors

2020-07-28 Thread Ajit Ghaisas
On Mon, 27 Jul 2020 10:07:31 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8249647 > Fix : Added missing explicit no-arg constructors to classes in package > javafx.beans.binding in module javafx.base. This pull request has now been integrated. Changeset:

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-07-28 Thread Nir Lisker
On Fri, 24 Jul 2020 21:41:04 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now >> contains 11 commits: >> - Merge branch 'master' into 8217472_Add_attenuation_for_PointLight >> - Attenuation and

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-07-28 Thread Kevin Rushforth
On Tue, 28 Jul 2020 13:15:02 GMT, Nir Lisker wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/PointLightHelper.java >> line 2: >> >>> 1: /* >>> 2: * Copyright (c) 2016, 2019, Oracle and/or its affiliates. All rights >>> reserved. >>> 3: * DO NOT ALTER OR REMOVE COPYRIGHT

Re: [jfx15] RFR: 8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors [v3]

2020-07-28 Thread Ajit Ghaisas
> Issue : https://bugs.openjdk.java.net/browse/JDK-8249647 > Fix : Added missing explicit no-arg constructors to classes in package > javafx.beans.binding in module javafx.base. Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision: add

Re: [jfx15] RFR: 8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors [v3]

2020-07-28 Thread Nir Lisker
On Tue, 28 Jul 2020 10:00:37 GMT, Ajit Ghaisas wrote: >> Issue : https://bugs.openjdk.java.net/browse/JDK-8249647 >> Fix : Added missing explicit no-arg constructors to classes in package >> javafx.beans.binding in module javafx.base. > > Ajit Ghaisas has updated the pull request incrementally

Seeking FXML examples with the "onChange" attribute defined for ObservableList, ObservableMap, ObservableSet ...

2020-07-28 Thread Rony G. Flatscher
Hi Nir, On 27.07.2020 22:39, Nir Lisker wrote: > Hi Rony, > > I think that this PR is not the place for this question since it only fixes a typo there. sorry, my bad, not realizing that the reply will be taken as part of the PR! This time with a proper new e-mail. --- In

Re: [jfx15] RFR: 8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors [v3]

2020-07-28 Thread Kevin Rushforth
On Tue, 28 Jul 2020 10:00:37 GMT, Ajit Ghaisas wrote: >> Issue : https://bugs.openjdk.java.net/browse/JDK-8249647 >> Fix : Added missing explicit no-arg constructors to classes in package >> javafx.beans.binding in module javafx.base. > > Ajit Ghaisas has updated the pull request incrementally

Re: RFR: 8217472: Add attenuation for PointLight [v6]

2020-07-28 Thread Nir Lisker
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 Nir Lisker has updated the pull request incrementally with three additional commits since the last revision: - Merge remote-tracking branch 'nlisker/8217472_Add_attenuation_for_PointLight' into 8217472_Add_attenuation_for_PointLight

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-07-28 Thread torbuntu
On Fri, 3 Jul 2020 13:49:54 GMT, Kevin Rushforth wrote: >> @pankaj-bansal Sorry for commiting again. Now the Tab Pane test works >> properly. > >> If you want these commits to be preserved when you integrate, you will need >> to make a 'merge-style' pull request. > > Please ignore this

Re: [jfx15] RFR: 8228570: Add various documentation clarifications [v2]

2020-07-28 Thread Nir Lisker
> Adds clarifications to the documentation in various places. Some notes: > > * Point 6 should probably be deferred until it is verified that the tutorials > are correct enough, seeing as they were > updated to Java 8 only. > * Point 8 has been deferred until all the animation bugs have been

Re: [jfx15] RFR: 8246343: Fix mistakes in FX API docs [v4]

2020-07-28 Thread Arun Joseph
On Mon, 27 Jul 2020 21:16:41 GMT, Nir Lisker wrote: >> Fixes https://bugs.openjdk.java.net/browse/JDK-8246343 and some additional >> fixes in the vicinity. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed review

Re: RFR: 8218973: SVG with masking is not rendering image with mask effect [v7]

2020-07-28 Thread Bhawesh Choudhary
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp > in WebKit was not implemented, so masking > doesn't take place at all while rendering SVGRect. to fix this issue add > implementation of function clipToImageBuffer() > in GraphicsContextJava.cpp and send clip image

Re: RFR: 8218973: SVG with masking is not rendering image with mask effect [v6]

2020-07-28 Thread Bhawesh Choudhary
On Fri, 24 Jul 2020 12:10:00 GMT, Arun Joseph wrote: >> Bhawesh Choudhary has updated the pull request incrementally with one >> additional commit since the last revision: >> >> HiDPI printing and Rendering fix > >

Re: [jfx15] RFR: 8246343: Fix mistakes in FX API docs [v5]

2020-07-28 Thread Nir Lisker
> Fixes https://bugs.openjdk.java.net/browse/JDK-8246343 and some additional > fixes in the vicinity. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Addressed review comments - Changes: - all:

Re: [jfx15] RFR: 8246343: Fix mistakes in FX API docs [v5]

2020-07-28 Thread Kevin Rushforth
On Tue, 28 Jul 2020 18:53:14 GMT, Nir Lisker wrote: >> Fixes https://bugs.openjdk.java.net/browse/JDK-8246343 and some additional >> fixes in the vicinity. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed review

Re: RFR: [WIP]8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v2]

2020-07-28 Thread Ambarish Rapte
> The issue occurs because the key events are consumed by the `ListView` in > `Popup`, which displays the items. > This is a regression of > [JDK-8077916](https://bugs.openjdk.java.net/browse/JDK-8077916). This change > aadded several > `KeyMapping`s for focus traversals to `ListView`, which