Re: RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina

2020-12-03 Thread Kevin Rushforth
On Thu, 3 Dec 2020 13:34:04 GMT, Kevin Rushforth wrote: >> I tested the patch, and it works for me (MacOS Catalina, 10.15.7) >> I will look into more detail in the code, as I'm slightly worried about not >> following the Apple conventions. From experience, this often leads to more >> issues

RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina

2020-12-03 Thread Kevin Rushforth
This is a proposed fix for the bug where the Apple system menubar is initially non-responsive on macOS 10.15 and later after a JavaFX application has started up. The end user can workaround this by switching to some other application and then back to the JavaFX app, but there is no known

Re: RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina

2020-12-03 Thread Kevin Rushforth
On Wed, 2 Dec 2020 20:00:55 GMT, Kevin Rushforth wrote: > This is a proposed fix for the bug where the Apple system menubar is > initially non-responsive on macOS 10.15 and later after a JavaFX application > has started up. The end user can workaround this by switching to some other >

Re: RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina

2020-12-03 Thread Kevin Rushforth
On Wed, 2 Dec 2020 20:05:03 GMT, Kevin Rushforth wrote: >> This is a proposed fix for the bug where the Apple system menubar is >> initially non-responsive on macOS 10.15 and later after a JavaFX application >> has started up. The end user can workaround this by switching to some other >>

Re: RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina

2020-12-03 Thread Johan Vos
On Wed, 2 Dec 2020 21:06:10 GMT, Kevin Rushforth wrote: >> I note that this does not seem to be a problem for Swing apps. AWT uses the >> Java Runtime Support (JRS) framework to initialize the application and >> menubar. > > Note to testers: `JFXPanel` applications deadlock with this fix. I

Re: RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina

2020-12-03 Thread Kevin Rushforth
On Thu, 3 Dec 2020 09:14:00 GMT, Johan Vos wrote: >> Note to testers: `JFXPanel` applications deadlock with this fix. I need to >> check whether glass is being started up for a normal Taskbar application, >> and not being embedded in an `FXCanvas` or `JFXPanel`. > > I tested the patch, and it

Re: RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina

2020-12-03 Thread Johan Vos
On Wed, 2 Dec 2020 20:00:55 GMT, Kevin Rushforth wrote: > This is a proposed fix for the bug where the Apple system menubar is > initially non-responsive on macOS 10.15 and later after a JavaFX application > has started up. The end user can workaround this by switching to some other >

Re: RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina

2020-12-03 Thread Johan Vos
On Thu, 3 Dec 2020 13:58:31 GMT, Kevin Rushforth wrote: >> Thanks for checking. I'll remove the debug print statements, turn off >> verbose logging, and send it out for review. I would appreciate a thorough >> review of the code. Given the way JavaFX initializes the macOS application >> and

Re: RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina

2020-12-03 Thread Kevin Rushforth
On Thu, 3 Dec 2020 16:23:47 GMT, Johan Vos wrote: >> This is a proposed fix for the bug where the Apple system menubar is >> initially non-responsive on macOS 10.15 and later after a JavaFX application >> has started up. The end user can workaround this by switching to some other >>

Re: RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina [v2]

2020-12-03 Thread Kevin Rushforth
On Thu, 3 Dec 2020 16:39:59 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/ui/mac/MacApplication.java >> line 142: >> >>> 140: @Override >>> 141: protected void notifyDidBecomeActive() { >>> 142: super.notifyDidBecomeActive(); >> >> if an

Re: RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina [v2]

2020-12-03 Thread Kevin Rushforth
> This is a proposed fix for the bug where the Apple system menubar is > initially non-responsive on macOS 10.15 and later after a JavaFX application > has started up. The end user can workaround this by switching to some other > application and then back to the JavaFX app, but there is no

Re: RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina [v2]

2020-12-03 Thread Johan Vos
On Thu, 3 Dec 2020 17:39:08 GMT, Kevin Rushforth wrote: >> This is a proposed fix for the bug where the Apple system menubar is >> initially non-responsive on macOS 10.15 and later after a JavaFX application >> has started up. The end user can workaround this by switching to some other >>

Re: RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina

2020-12-03 Thread Johan Vos
On Wed, 2 Dec 2020 20:00:55 GMT, Kevin Rushforth wrote: > This is a proposed fix for the bug where the Apple system menubar is > initially non-responsive on macOS 10.15 and later after a JavaFX application > has started up. The end user can workaround this by switching to some other >

RFR: 8231372: JFXPanel fails to render if setScene called on Swing thread

2020-12-03 Thread Kevin Rushforth
This fix was originally proposed by @mruzicka in PR #16 which was closed several months ago without being integrated. At the time we didn't have a test case that was failing. While evaluating a bug that I filed, [JDK-8235843](https://bugs.openjdk.java.net/browse/JDK-8235843), I discovered

Re: RFR: 8231372: JFXPanel fails to render if setScene called on Swing thread

2020-12-03 Thread Prasanta Sadhukhan
On Fri, 4 Dec 2020 02:07:37 GMT, Kevin Rushforth wrote: > This fix was originally proposed by @mruzicka in PR #16 which was closed > several months ago without being integrated. At the time we didn't have a > test case that was failing. > > While evaluating a bug that I filed, >

Integrated: 8254049: Update WebView to public suffix list 2020-04-24

2020-12-03 Thread Arun Joseph
On Mon, 19 Oct 2020 04:29:13 GMT, Arun Joseph wrote: > We should use the public_suffix_list.dat file in the JDK instead. Reading the > public_suffix_list.dat file is modified to be similar to >