> This is a PoC for performance testing.
>
> It contains commented out code in PopupWindow and ProgressIndicatorSkin and
> two tests are failing because of that.
>
> This code avoids registering two listeners (on Scene and on Window) for each
> and every Node to support the aforementioned
On Fri, 22 Jan 2021 21:32:28 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> WIP: Moved treeShowingProperty into its own class
>
>
On Sun, 24 Jan 2021 09:24:56 GMT, John Hendrikx wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ProgressIndicatorSkin.java
>> line 239:
>>
>>> 237: super.dispose();
>>> 238:
>>> 239: treeShowingExpression.dispose();
>>
>> This could be removed if you
On Fri, 22 Jan 2021 21:36:53 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> WIP: Moved treeShowingProperty into its own class
>
> I left a few inline comments
On Fri, 22 Jan 2021 21:31:42 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> WIP: Moved treeShowingProperty into its own class
>
>
> This is a new approach to rewrite parts of gtk glass backend to be more clean.
>
> I will provide small "manageable" PR to incrementally make the backend better.
>
> This PR adresses cleanup of the Size and Positioning code. It makes code more
> "straightforward" and easier to maintain.
>
>
On Tue, 22 Sep 2020 01:12:44 GMT, Thiago Milczarek Sayao
wrote:
>> Rebased onto "master" and squashed commits.
>
> Tested on Ubuntu 20.04
>
> 756 tests completed, 6 failed, 110 skipped
>
> Failed:
> test.robot.javafx.scene.ColorPickerTest > testColorPickerSceneChange FAILED
>
> This is a new approach to rewrite parts of gtk glass backend to be more clean.
>
> I will provide small "manageable" PR to incrementally make the backend better.
>
> This PR adresses cleanup of the Size and Positioning code. It makes code more
> "straightforward" and easier to maintain.
>
>
> This is a PoC for performance testing.
>
> It contains commented out code in PopupWindow and ProgressIndicatorSkin and
> two tests are failing because of that.
>
> This code avoids registering two listeners (on Scene and on Window) for each
> and every Node to support the aforementioned
On Sun, 24 Jan 2021 09:02:17 GMT, John Hendrikx wrote:
>> I left a few inline comments below.
>
> Sorry about the force push, merging over a year of changes from master did
> not seem right to me. It was only for getting up to date, I will do the
> other commits normally.
> 1. Merge in the
On Sat, 23 Jan 2021 23:11:10 GMT, Nir Lisker wrote:
>> The JavaFX API does not provide a way to get the state of CAPS LOCK or NUM
>> LOCK on the keyboard. Being able to read the lock state would allow an
>> application to inform the user that caps lock was enabled for passwords or
>> other
On Sun, 24 Jan 2021 14:50:08 GMT, Frederic Thevenet
wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Application.java line
>> 764:
>>
>>> 762: default:
>>> 763: return Optional.empty();
>>> 764: }
>>
>> This could be a switch expression:
>>
On Sun, 24 Jan 2021 15:03:52 GMT, Matthias Bläsing
wrote:
>> Do we plan to drop support for JDK11 for OpenJFX 17? If not, we'll need to
>> keep to the classic Switch statement, as Switch expressions were only
>> introduced in JDK12 or 13 as a preview.
>> That said, since 17 is going to be the
On Sun, 24 Jan 2021 18:09:03 GMT, Nir Lisker wrote:
> Formally, OpenJFX N supports JDK N-1, so for 17 we should be able to use
> features from 16. It was decided a while back not to force-fail on older JDK
> versions and let it evolve naturally.
That's the bit of information I was missing,
14 matches
Mail list logo
