Anyone mind if I take a crack at 8177635: Optimise CSS lookup resolution?
I'm looking at a broader issue which is the amount of time spent looking up the
parent chain to resolve a style. My thought is to push parent state down to
children as CSS is applied. The state would include pseudoclass, font, and
styles that might need looking up.
But I like your change. It
On Fri, 29 Jan 2021 12:19:51 GMT, Tom Schindl wrote:
>> As indicated in the JBS bug, using a `PixelReader` to read a scaled image in
>> HiDPI mode, for example an `@2x` image, to read more than one pixel will
>> read data from the wrong location in the image, usually leading to an IOOBE.
>>
On Fri, 29 Jan 2021 12:25:53 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/com/sun/prism/Image.java line 654:
>>
>>> 652: }
>>> 653: if (pixelScale != 1.0f) {
>>> 654: pixelaccessor = new ScaledAccessor<>(pixelaccessor,
>>>
On Fri, 29 Jan 2021 00:05:57 GMT, Kevin Rushforth wrote:
> As indicated in the JBS bug, using a `PixelReader` to read a scaled image in
> HiDPI mode, for example an `@2x` image, to read more than one pixel will read
> data from the wrong location in the image, usually leading to an IOOBE.
>
>
On Mon, 25 Jan 2021 23:08:58 GMT, Kevin Rushforth wrote:
>> The JavaFX API does not provide a way to get the state of CAPS LOCK or NUM
>> LOCK on the keyboard. Being able to read the lock state would allow an
>> application to inform the user that caps lock was enabled for passwords or
>>
> The JavaFX API does not provide a way to get the state of CAPS LOCK or NUM
> LOCK on the keyboard. Being able to read the lock state would allow an
> application to inform the user that caps lock was enabled for passwords or
> other usages where the keyboard input might not be echoed. It
On Fri, 29 Jan 2021 07:08:47 GMT, Ambarish Rapte wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use XkbGetNamedIndicator on Linux instead of relying on the (unreliable)
>> GDK method.
>
>
On Thu, 21 Jan 2021 04:14:28 GMT, Arun Joseph wrote:
> Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
This pull request has now been integrated.
Changeset: b0a404de
Author:Arun Joseph
URL: https://git.openjdk.java.net/jfx/commit/b0a404de
Stats: 257339 lines in 5451 files
On Fri, 29 Jan 2021 13:19:00 GMT, Kevin Rushforth wrote:
>> The JavaFX API does not provide a way to get the state of CAPS LOCK or NUM
>> LOCK on the keyboard. Being able to read the lock state would allow an
>> application to inform the user that caps lock was enabled for passwords or
>>
On Thu, 28 Jan 2021 11:48:02 GMT, Ambarish Rapte wrote:
>> This particular issue JDK-8256283, is a specific case of IOOBE when,
>> rootItem is not shown, some children including first child are selected,
>> then all children are removed and sort() is invoked. The sort() fails with
>> an
Hi David,
That would be great, if a safe fix can be found (I don't need to tell
you how fragile the CSS code is when it comes to these sorts of
optimizations).
Thanks!
-- Kevin
On 1/29/2021 7:02 AM, David Grieve wrote:
Anyone mind if I take a crack at 8177635: Optimise CSS lookup
On Fri, 22 Jan 2021 10:08:51 GMT, Ambarish Rapte wrote:
> This particular issue JDK-8256283, is a specific case of IOOBE when, rootItem
> is not shown, some children including first child are selected, then all
> children are removed and sort() is invoked. The sort() fails with an IOOBE.
>
On Mon, 18 Jan 2021 15:07:34 GMT, Nir Lisker wrote:
> The usual doc fixes (for OpenJFX 16).
>
> Can wait until RDP2 to see if something else comes up.
@nlisker I'll wait to review this until after you add the fix noted in
[JDK-8260430](https://bugs.openjdk.java.net/browse/JDK-8260430).
On Thu, 21 Jan 2021 15:57:04 GMT, Arun Joseph wrote:
>> Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
>
> Arun Joseph has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix color in DefaultPlugin
Marked as reviewed by jvos (Reviewer).
> The usual doc fixes (for OpenJFX 16).
>
> Can wait until RDP2 to see if something else comes up.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Fix for 8260430
-
Changes:
- all:
On Fri, 29 Jan 2021 13:20:38 GMT, Kevin Rushforth wrote:
>> The usual doc fixes (for OpenJFX 16).
>>
>> Can wait until RDP2 to see if something else comes up.
>
> @nlisker I'll wait to review this until after you add the fix noted in
>
Hi David,
We experimented with some changes last year which we've been running. We
haven't noticed any problems and we do get some good memory and speed
enhancements.. I've been meaning to clean it up before considering a pull
request, but since this is a delicate area, I've procrastinated a bit
18 matches
Mail list logo
