Re: RFR: 8255713: JavaFX build should discover Visual Studio compiler on system

2021-03-17 Thread Ambarish Rapte
On Tue, 16 Mar 2021 16:30:51 GMT, Kevin Rushforth wrote: > We currently hard-code the default version of Visual Studio in both > `win.gradle` and `.github/workflows/submit.yml`. This hard-coding of the > specific version of MSVC is fragile, particularly for GitHub action builds. > The last tim

RFR: 8208088: Memory Leak in ControlAcceleratorSupport

2021-03-17 Thread Ambarish Rapte
The method `ControlAcceleratorSupport.doAcceleratorInstall(final List items, final Scene scene)` adds a `ChangeListener` on `MenuItem.acceleratorProperty()`. This listener is not removed when the MenuItem is removed from scenegraph. Adding and removing a MenuItem results in multiple copies of the

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

2021-03-17 Thread Kevin Rushforth
On Wed, 17 Mar 2021 18:17:48 GMT, Kevin Rushforth wrote: > This is a fix for a long-standing bug where the D3D pipeline will stop > rendering when a Windows remote desktop session is disconnected and then > reconnected. > > A preliminary Draft PR #315 by @Schmidor was a good first step in solv

RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

2021-03-17 Thread Kevin Rushforth
This is a fix for a long-standing bug where the D3D pipeline will stop rendering when a Windows remote desktop session is disconnected and then reconnected. A preliminary Draft PR #315 by @Schmidor was a good first step in solving this. I took that and continued the work in my Draft PR #403. It

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

2021-03-17 Thread Kevin Rushforth
On Tue, 16 Feb 2021 15:42:51 GMT, Kevin Rushforth wrote: >> This is a good starting point, but it will need additional work, possibly in >> the native D3D code as well as on the Java side, to fully cleanup and >> recreate all of the resources after the device is recreated. As discussed >> offl

Withdrawn: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

2021-03-17 Thread Kevin Rushforth
On Thu, 8 Oct 2020 16:07:08 GMT, Oliver Schmidtmer wrote: > When connecting via Remote Desktop to a Windows 10 machine ans starting a > JavaFX application, the D3D pipeline is used successfully. > After closing the the Remote Desktop session and reconnecting, the D3D > requests fail with an D3

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

2021-03-17 Thread Kevin Rushforth
On Wed, 17 Mar 2021 18:23:07 GMT, Kevin Rushforth wrote: >> This is a fix for a long-standing bug where the D3D pipeline will stop >> rendering when a Windows remote desktop session is disconnected and then >> reconnected. >> >> A preliminary Draft PR #315 by @Schmidor was a good first step in

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport

2021-03-17 Thread Kevin Rushforth
On Wed, 17 Mar 2021 17:35:34 GMT, Ambarish Rapte wrote: > The method `ControlAcceleratorSupport.doAcceleratorInstall(final List extends MenuItem> items, final Scene scene)` adds a `ChangeListener` on > `MenuItem.acceleratorProperty()`. This listener is not removed when the > MenuItem is removed

Re: RFR: 8255713: JavaFX build should discover Visual Studio compiler on system

2021-03-17 Thread Johan Vos
On Tue, 16 Mar 2021 16:30:51 GMT, Kevin Rushforth wrote: > We currently hard-code the default version of Visual Studio in both > `win.gradle` and `.github/workflows/submit.yml`. This hard-coding of the > specific version of MSVC is fragile, particularly for GitHub action builds. > The last tim

Integrated: 8255713: JavaFX build should discover Visual Studio compiler on system

2021-03-17 Thread Kevin Rushforth
On Tue, 16 Mar 2021 16:30:51 GMT, Kevin Rushforth wrote: > We currently hard-code the default version of Visual Studio in both > `win.gradle` and `.github/workflows/submit.yml`. This hard-coding of the > specific version of MSVC is fragile, particularly for GitHub action builds. > The last tim

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop [v2]

2021-03-17 Thread Kevin Rushforth
> This is a fix for a long-standing bug where the D3D pipeline will stop > rendering when a Windows remote desktop session is disconnected and then > reconnected. > > A preliminary Draft PR #315 by @Schmidor was a good first step in solving > this. I took that and continued the work in my Draft

Re: RFR: 8092439: [Monocle] Refactor monocle SPI to allow support for multiple screens

2021-03-17 Thread Kevin Rushforth
On Tue, 16 Mar 2021 14:24:19 GMT, Johan Vos wrote: > Fix for JDK-8092439 and JDK-8092064 > Monocle currently hard-codes a single Screen, and the > `staticScreen_getScreens()` method will never return more than 1 Screen. > > This PR introduces the possibility to deal with multiple screens, which

Fwd: Implementing a shader API

2021-03-17 Thread Jacky Guo
-- Forwarded message - From: Jacky Guo Date: Wed, Mar 17, 2021 at 8:08 PM Subject: Re: Implementing a shader API To: Johan Vos I've cobbled together a prototype API. This is of course non-functional, but I'd like feedback on it. I'm going to work backwards to figure out what I n