Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v9]

2021-03-22 Thread Kevin Rushforth
On Mon, 22 Mar 2021 23:00:05 GMT, Nir Lisker wrote: >>> There is an outstanding API question regarding the direction vector: Should >>> the transforms of the SpotLight node to scene coordinates affect the >>> direction vector (e.g., such that a rotation would rotate the direction the >>>

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v9]

2021-03-22 Thread Kevin Rushforth
On Sun, 21 Mar 2021 17:48:10 GMT, Nir Lisker wrote: > I would like to allow a developer to achieve a functionality like is shown in > https://www.youtube.com/watch?v=CFgwZX5dkcM at 9:50. The rotations are > intuitive there. If we allow both rotation transforms and a direction, > wouldn't that

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v9]

2021-03-22 Thread Nir Lisker
On Sun, 21 Mar 2021 17:48:10 GMT, Nir Lisker wrote: >> Finally getting back to this. >> >> There is an outstanding API question regarding the direction vector: Should >> the transforms of the SpotLight node to scene coordinates affect the >> direction vector (e.g., such that a rotation would

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v11]

2021-03-22 Thread Nir Lisker
> Added a SpotLight only to the D3D pipeline currently. > > ### API discussion points > > - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could also > be a subclass of `PointLight` as it's a point light with direction and extra > factors. I saw that

Re: Not really a nice comment but a real issue?

2021-03-22 Thread Philip Race
I am informed that, for no reason given, the corporate IT folks will not allow attachment upload. Attempts over the years to persuade them otherwise have failed. The best suggestion is you upload it somewhere else and include the link in the bug report and the Oracle reviewer can grab it.

RFR: 8264010: Add Gradle dependency verification

2021-03-22 Thread John Neffenger
This pull request adds dependency verification to the Gradle builds of JavaFX on Linux, macOS, and Windows. It is the third of three changes that close the gaps in the JavaFX build security: * [JDK-8262236][1]: Configure Gradle checksum verification * [JDK-8263204][2]: Add Gradle Wrapper

Re: user mailing list

2021-03-22 Thread Zsolt Kúti
Thanks! On Fri, Mar 19, 2021 at 4:16 PM Nir Lisker wrote: > The mailing lists are only for development and discussion purposes. If you > think there's a bug or a missing feature you can ask here, but if you need > help then there is no formal mailing list for that. > If SO didn't help, you can

Re: Not really a nice comment but a real issue?

2021-03-22 Thread Kevin Rushforth
I had missed that as well. I'll close the bug I filed as a duplicate and raise the priority of that bug. -- Kevin On 3/20/2021 11:54 AM, Philip Race wrote: Ah, I missed that. And with that, I've now found Gary's bug : https://bugs.openjdk.java.net/browse/JDK-8239138 -phil. On 3/20/21

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene [v3]

2021-03-22 Thread Florian Kirmaier
> Fixing a memory leak. > A node hard references its old parent after CSS layout and getting removed. > This shouldn't be the case, this is very counterintuitive. > > The fix uses a WeakReference in CSSStyleHelper for firstStyleableAncestor. > This should be fine because the CSS should only

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene

2021-03-22 Thread Kevin Rushforth
On Mon, 22 Mar 2021 14:35:58 GMT, Florian Kirmaier wrote: >> Below is a fix that I tried, It fixes the issue. The system test passed with >> this change. >> I was suggesting a solution like this where we can know exactly when to >> `null` the reference. The change is not extensively tested

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene

2021-03-22 Thread Florian Kirmaier
On Mon, 15 Mar 2021 18:59:40 GMT, Ambarish Rapte wrote: >> About whether we should use WeakReference here or not. >> >> It definitely falls into the exception for referring to the Parrent of a >> Node. (Or to the Parent in a more abstract sense, I think it can also be the >> parent of the

Re: RFR: 8263322: Calling Application.launch on FX thread should throw IllegalStateException, but causes deadlock [v9]

2021-03-22 Thread Kevin Rushforth
On Sun, 21 Mar 2021 22:30:11 GMT, Florian Kirmaier wrote: >> Fixing deadlock when calling Application.launch in the FXThread after >> Platform.startup > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8263322 >