On Tue, 8 Jun 2021 07:42:19 GMT, Johan Vos wrote:
> 8207837: Indeterminate ProgressBar does not animate if content is added after
> scene is set on window
>
> Add or remove the windowShowingChangedListener when the scene changes
>
> Reviewed-by: arapte, kcr
This pull request has now been
On Tue, 8 Jun 2021 08:34:30 GMT, Johan Vos wrote:
> Reviewed-by: pbansal, kcr
This pull request has now been integrated.
Changeset: 259cd4f9
Author:Johan Vos
URL:
https://git.openjdk.java.net/jfx11u/commit/259cd4f91b050263a178079966b5f71e5a21b207
Stats: 15 lines in 2 files
On Tue, 8 Jun 2021 11:51:32 GMT, Ambarish Rapte wrote:
>> Issue:
>> There are several issues related to Accelerator of MenuItem of a ConextMenu
>> set on Control.
>> 1. Accelerator of ContextMenu's MenuItem is not removed when ContextMenu is
>> removed from Scene
>> 2. Accelerator is not
On Tue, 8 Jun 2021 08:37:45 GMT, Johan Vos wrote:
> …xception: Index 4096 out of bounds for length 4096
>
> Reviewed-by: kcr, arapte
This pull request has now been integrated.
Changeset: db9b1b74
Author:Johan Vos
URL:
On Sat, 5 Jun 2021 17:31:17 GMT, Michael Strauß wrote:
>> This PR adds support for loading images from [inline data
>> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
>> supported by web browsers. This enables developers to package small images
>> in CSS files,
On Wed, 21 Apr 2021 18:17:27 GMT, Michael Strauß wrote:
> This PR adds the `Node.focusVisible` and `Node.focusWithin` properties, as
> well as the corresponding `:focus-visible` and `:focus-within` CSS
> pseudo-classes.
I took an initial pass at the API docs. I have a couple global comments.
I very much like the idea of a simpler way to create Borders and Backgrounds,
but once you get beyond the original proposal of Border.stroke(Paint stroke),
it seems like a case where a fluent interface would be useful. The
alternatives of multiple argument constructors just start getting back
On Wed, 9 Jun 2021 13:01:17 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - wording
>> - Re-ordered methods
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 8167:
>
I'm not entirely convinced taking width is all that useful. The (final)
pxiel width of a border is normally a calculated value based on the
chosen unit and scaling needs of the platform.
A lot of methods in JavaFX work with pixel values only, while for proper
scaling I often find myself
On Wed, 9 Jun 2021 13:18:29 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added comment, simplified DataURI.matchScheme()
>
>
> This PR adds support for loading images from [inline data
> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
> supported by web browsers. This enables developers to package small images in
> CSS files, rather than separately deploying the images alongside the CSS
> This PR adds the `Node.focusVisible` and `Node.focusWithin` properties, as
> well as the corresponding `:focus-visible` and `:focus-within` CSS
> pseudo-classes.
Michael Strauß has updated the pull request incrementally with two additional
commits since the last revision:
- wording
-
On Wed, 9 Jun 2021 14:20:41 GMT, Michael Strauß wrote:
>> This PR adds support for loading images from [inline data
>> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
>> supported by web browsers. This enables developers to package small images
>> in CSS files,
The inconsistent illumination happens on Macs with retina displays only if the
3D shape is placed in a SubScene. The light sources are located with wrong
coordinates in sub scenes and this causes a different illumination. The wrong
coordinates for the light sources come from the fact that the
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact
On Wed, 9 Jun 2021 18:02:30 GMT, Andreas Heger
wrote:
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
>
On Wed, 9 Jun 2021 18:22:31 GMT, Andreas Heger
wrote:
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
>
The inconsistent illumination happens on Macs with retina displays only if the
3D shape is placed in a SubScene. The light sources are located with wrong
coordinates in sub scenes and this causes a different illumination. The wrong
coordinates for the light sources come from the fact that the
On Wed, 9 Jun 2021 18:46:16 GMT, Kevin Rushforth wrote:
> @andreas-heger Welcome to the `jfx` project. At a quick glance, the fix looks
> promising. Have you tested this on Windows with Hi-DPI to make sure there is
> no impact?
No, I only have got MacOS on retina / non retina and a non Hi-DPI
On Wed, 9 Jun 2021 18:46:16 GMT, Kevin Rushforth wrote:
> I intend to test this alone and in connection with your PR.
Alright. I'll keep an eye on this PR.
-
PR: https://git.openjdk.java.net/jfx/pull/531
20 matches
Mail list logo
