Integrated: 8270839: Remove deprecated implementation methods from Scene

2021-07-22 Thread Kevin Rushforth
On Fri, 16 Jul 2021 17:53:21 GMT, Kevin Rushforth wrote: > This removes following implementation methods in Scene by making them > package-scope. They were previously deprecated for removal by > [JDK-8270246](https://bugs.openjdk.java.net/browse/JDK-8270246): > > > public void

[jfx17] RFR: 8271086: Block comments of form '/***' are treated as javadoc comments

2021-07-22 Thread Kevin Rushforth
This fix for [JDK-8271086](https://bugs.openjdk.java.net/browse/JDK-8271086) is part of a larger cleanup effort to find and fix places where we have missing or redundant API comments. See [JDK-8271083](https://bugs.openjdk.java.net/browse/JDK-8271083). This fixes a long-standing problem dating

Re: RFR: 8188026: TextFieldXXCell: NPE on calling startEdit

2021-07-22 Thread Marius Hanl
On Mon, 12 Jul 2021 12:49:15 GMT, Jeanette Winzenburg wrote: > > > just checked my notes (there's a cell-editing branch in my fork where I'm > > > experimenting) - astonishingly the answer is no, could not see anything > > > :) And actually, seems like we don't even need to return

Re: [jfx17] RFR: 8270959: Update boot JDK to 16.0.2

2021-07-22 Thread Johan Vos
On Tue, 20 Jul 2021 18:58:08 GMT, Kevin Rushforth wrote: > Update boot JDK used to build JavaFX to JDK 16.0.2, which supersedes 16.0.1. > > NOTE: this is targeted to `jfx17`. We'll check on all platforms. - PR: https://git.openjdk.java.net/jfx/pull/583

Re: RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel [v5]

2021-07-22 Thread Marius Hanl
> This PR fixes multiple NPEs in Choice-and ComboBox, when the selection model > is null. > > ChoiceBox: > - Null check in **valueProperty()** listener > > ComboBox: > - Null check in **editableProperty()* listener* > - Null check in **valueProperty()** listener > - Null check in

Re: RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel [v4]

2021-07-22 Thread Marius Hanl
On Wed, 7 Jul 2021 19:37:23 GMT, Marius Hanl wrote: >> This PR fixes multiple NPEs in Choice-and ComboBox, when the selection model >> is null. >> >> ChoiceBox: >> - Null check in **valueProperty()** listener >> >> ComboBox: >> - Null check in **editableProperty()* listener* >> - Null check

Re: RFR: 8270839: Remove deprecated implementation methods from Scene [v2]

2021-07-22 Thread Ambarish Rapte
On Tue, 20 Jul 2021 20:37:17 GMT, Kevin Rushforth wrote: >> This removes following implementation methods in Scene by making them >> package-scope. They were previously deprecated for removal by >> [JDK-8270246](https://bugs.openjdk.java.net/browse/JDK-8270246): >> >> >> public void

Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed

2021-07-22 Thread Florian Kirmaier
On Wed, 21 Jul 2021 11:29:38 GMT, Florian Kirmaier wrote: > After thinking about this issue for some time, I've now got a solution. > I know put the scene in the state it is, before is was shown, when the > dirtyNodes are unset, the whole scene is basically considered dirty. > This has the

Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v2]

2021-07-22 Thread Florian Kirmaier
> After thinking about this issue for some time, I've now got a solution. > I know put the scene in the state it is, before is was shown, when the > dirtyNodes are unset, the whole scene is basically considered dirty. > This has the drawback of rerendering, whenever a window is "reshown", but it

Re: [jfx17] RFR: 8270959: Update boot JDK to 16.0.2

2021-07-22 Thread Kevin Rushforth
On Tue, 20 Jul 2021 18:58:08 GMT, Kevin Rushforth wrote: > Update boot JDK used to build JavaFX to JDK 16.0.2, which supersedes 16.0.1. > > NOTE: this is targeted to `jfx17`. @johanvos or @tiainen can one of you be the second reviewer for this? - PR:

Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v2]

2021-07-22 Thread Kevin Rushforth
On Thu, 22 Jul 2021 11:50:11 GMT, Florian Kirmaier wrote: >> After thinking about this issue for some time, I've now got a solution. >> I know put the scene in the state it is, before is was shown, when the >> dirtyNodes are unset, the whole scene is basically considered dirty. >> This has

Re: RFR: 8270839: Remove deprecated implementation methods from Scene [v2]

2021-07-22 Thread Ajit Ghaisas
On Tue, 20 Jul 2021 20:37:17 GMT, Kevin Rushforth wrote: >> This removes following implementation methods in Scene by making them >> package-scope. They were previously deprecated for removal by >> [JDK-8270246](https://bugs.openjdk.java.net/browse/JDK-8270246): >> >> >> public void

Re: RFR: 8270839: Remove deprecated implementation methods from Scene [v2]

2021-07-22 Thread Kevin Rushforth
On 7/22/2021 6:44 AM, Ajit Ghaisas wrote: Marked as reviewed by aghaisas (Reviewer). I'll integrate as soon as the CSR is approved (I've moved it to "Finalized"). (Btw, I'm replying directly to the email list to see whether Skara's `mlbridge` bot is working in this direction following the

Re: [jfx17] RFR: 8240640: [macos] Wrong focus behaviour with multiple Alerts

2021-07-22 Thread Kevin Rushforth
On Mon, 19 Jul 2021 19:52:05 GMT, Pankaj Bansal wrote: > The bug is a regression as a result of fix done for JDK-8227366 and is > reproducible on Linux and Mac. This fix is being reverted in this change and > a new bug (JDK-8271054) has been created to redo the JDK-8227366 > > An automated