Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels

2021-08-15 Thread Thiago Milczarek Sayao
On Sun, 15 Aug 2021 16:26:59 GMT, Pankaj Bansal wrote: >> Test works on Linux, don't know on other platforms. >> >> `gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests >> test.robot.javafx.dnd.DndRawImageTest` > >> Test works on Linux, don't know on other platforms. >> >>

Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels [v2]

2021-08-15 Thread Thiago Milczarek Sayao
On Wed, 11 Aug 2021 23:42:47 GMT, Thiago Milczarek Sayao wrote: >> It seems raw images need to be converted BRGA -> RGBA. >> >> It was being converted on gtk2 code path, but gtk3 only uses >> `gtk_drag_set_icon_pixbuf`. >> >> I have simplified the gtk2 `DragView::View::expose` to paint with

Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels

2021-08-15 Thread Pankaj Bansal
On Sun, 15 Aug 2021 16:26:59 GMT, Pankaj Bansal wrote: >> Test works on Linux, don't know on other platforms. >> >> `gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests >> test.robot.javafx.dnd.DndRawImageTest` > >> Test works on Linux, don't know on other platforms. >> >>

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation

2021-08-15 Thread Thiago Milczarek Sayao
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao wrote: > Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window =

Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels [v3]

2021-08-15 Thread Thiago Milczarek Sayao
> It seems raw images need to be converted BRGA -> RGBA. > > It was being converted on gtk2 code path, but gtk3 only uses > `gtk_drag_set_icon_pixbuf`. > > I have simplified the gtk2 `DragView::View::expose` to paint with > `gdk_cairo_set_source_pixbuf` (that is available since Gtk 2.8)

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation

2021-08-15 Thread Pankaj Bansal
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao wrote: > Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window =

Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels

2021-08-15 Thread Pankaj Bansal
On Wed, 11 Aug 2021 23:40:00 GMT, Thiago Milczarek Sayao wrote: > Test works on Linux, don't know on other platforms. > > `gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests > test.robot.javafx.dnd.DndRawImageTest` The fix does solve the issue and looks good to me. The test

java: module not found: eu.hansolo.medusa

2021-08-15 Thread Davide Perini
Hi all, I'm trying to use the medusa gauges. I have added those lines to my pom.xml eu.hansolo Medusa 16.0.0 and this to my module-info.java requires eu.hansolo.medusa; I can compile use mvn clean install but I cannot run my main file from intellij. I get this error: java: module not

Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels [v3]

2021-08-15 Thread Thiago Milczarek Sayao
On Sun, 15 Aug 2021 21:18:51 GMT, Thiago Milczarek Sayao wrote: >> It seems raw images need to be converted BRGA -> RGBA. >> >> It was being converted on gtk2 code path, but gtk3 only uses >> `gtk_drag_set_icon_pixbuf`. >> >> I have simplified the gtk2 `DragView::View::expose` to paint with