On Fri, 24 Sep 2021 20:05:01 GMT, John Hendrikx wrote:
> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
> still work. Also added a single JUnit 5 tests, and confirmed it works.
>
> I've updated the Eclipse project file for the base module only.
Sorry for the
> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
> still work. Also added a single JUnit 5 tests, and confirmed it works.
>
> I've updated the Eclipse project file for the base module only.
John Hendrikx has refreshed the contents of this pull request, and
I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
still work. Also added a single JUnit 5 tests, and confirmed it works.
I've updated the Eclipse project file for the base module only.
-
Commit messages:
- Add JUnit 5
Changes:
On Fri, 24 Sep 2021 10:43:31 GMT, Ajit Ghaisas wrote:
>> Marius Hanl has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Merge branch 'master' of https://github.com/openjdk/jfx into
>> 8231644-indentation
>>
On Tue, 7 Sep 2021 14:53:50 GMT, Jeanette Winzenburg
wrote:
> this PR fixes the inconsistent event firing pattern in cell's xxEdit methods
> (please see the issue for more details):
>
> - fires event if column != null
> - accesses table state if table != null
>
> The first requires a change
On Fri, 24 Sep 2021 10:48:53 GMT, Ajit Ghaisas wrote:
> Overall the fix looks ok. The new test fails without the fix and passes with
> it.
>
> Can you please confirm the test programs provided in 2 duplicated bugs of
> JDK-8231644 also work as expected with this fix?
Just tried them. They
Cleanup of Tree-/TableRowSkin to support switching skins
The misbehavior/s
- memory leaks due to manually registered listeners that were not removed
- side-effects due to listeners still active on old skin (like NPEs)
Fix
- use skin api for all listener registration (for automatic removal in
On Thu, 23 Sep 2021 19:26:47 GMT, Ambarish Rapte wrote:
> Cherry pick the GTK webkit 2.32.4 changes
> https://webkitgtk.org/2021/09/17/webkitgtk2.32.4-released.html
This pull request has now been integrated.
Changeset: 478512b7
Author:Ambarish Rapte
URL:
On Fri, 24 Sep 2021 20:36:30 GMT, Kevin Rushforth wrote:
>> John Hendrikx has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
>
On Fri, 24 Sep 2021 20:49:00 GMT, John Hendrikx wrote:
>> gradle/verification-metadata.xml line 273:
>>
>>> 271: >> version="1.3">
>>> 272:
>>> 273: >> value="66fdef91e9739348df7a096aa384a5685f4e875584cce89386a7a47251c4d8e9"
>>> origin="Generated by Gradle"/>
>>
>>
On Fri, 24 Sep 2021 20:48:26 GMT, John Hendrikx wrote:
>> gradle/verification-metadata.xml line 247:
>>
>>> 245: >> value="e08028131375b357d1d28734e9a4fb4216da84b240641cb3ef7e7c7d628223fc"
>>> origin="Generated by Gradle"/>
>>> 246:
>>> 247:
>>
>> Is `apiguardian`
> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
> still work. Also added a single JUnit 5 tests, and confirmed it works.
>
> I've updated the Eclipse project file for the base module only.
John Hendrikx has updated the pull request incrementally with two
Posting this to gauge the interest in adding JUnit 5 as a test
dependency to JavaFX, enabling writing tests with this new version of
JUnit while still supporting all JUnit 4 tests.
A draft PR has been submitted here: https://github.com/openjdk/jfx/pull/633
And an issue has been filed here:
On Fri, 24 Sep 2021 20:41:19 GMT, John Hendrikx wrote:
>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
>> still work. Also added a single JUnit 5 tests, and confirmed it works.
>>
>> I've updated the Eclipse project file for the base module only.
>
> John
On Fri, 24 Sep 2021 20:31:14 GMT, Kevin Rushforth wrote:
>> John Hendrikx has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> gradle/verification-metadata.xml
On Fri, 24 Sep 2021 20:25:48 GMT, John Hendrikx wrote:
> Sorry for the force push, forgot I already submitted it as a PR.
That's OK. I deleted the couple of comments I had added relating to blocks that
disappeared.
-
PR: https://git.openjdk.java.net/jfx/pull/633
> This PR fixes JDK-8274137 by removing the optimization from updateHbar() that
> will no-op the method in case the VirtualFlow is invisible or currently has
> no scene.
> Since changes to the hBar's value can happen even if the VirtualFlow is not
> currently visible, the synchronisation
On Tue, 27 Jul 2021 05:45:50 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue with the TreeTableView indentation.
>>
>> 
>>
>> In short:
>> **TreeTableCellSkin**
On Fri, 24 Sep 2021 06:16:55 GMT, Robert Lichtenberger
wrote:
> > First, this has the potential to hurt performance for applications that do
> > a lot of setup on tables that aren't visible.
>
> That would be possible if the hbar changes its visibility or its value. I
> can't really see how
On Fri, 24 Sep 2021 06:28:30 GMT, Robert Lichtenberger
wrote:
>> This PR fixes JDK-8274137 by removing the optimization from updateHbar()
>> that will no-op the method in case the VirtualFlow is invisible or currently
>> has no scene.
>> Since changes to the hBar's value can happen even if
On Tue, 7 Sep 2021 14:53:50 GMT, Jeanette Winzenburg
wrote:
> this PR fixes the inconsistent event firing pattern in cell's xxEdit methods
> (please see the issue for more details):
>
> - fires event if column != null
> - accesses table state if table != null
>
> The first requires a change
I don't have an objection to adding this one additional convenience
method if it is generally useful. If there aren't a lot of applications
that would use it, it seems better to go with just the two identified so
far and consider this one later.
So: would this be a generally useful addition?
I don't have a strong opinion on this addition.
On Fri, Sep 24, 2021 at 2:47 PM Kevin Rushforth
wrote:
> I don't have an objection to adding this one additional convenience
> method if it is generally useful. If there aren't a lot of applications
> that would use it, it seems better to go with
On Thu, 23 Sep 2021 19:26:47 GMT, Ambarish Rapte wrote:
> Cherry pick the GTK webkit 2.32.4 changes
> https://webkitgtk.org/2021/09/17/webkitgtk2.32.4-released.html
build & tests ok on mac(x86_64 and aarch64)/linux/win
-
Marked as reviewed by jvos (Reviewer).
PR:
24 matches
Mail list logo
