On Fri, 12 Nov 2021 22:42:35 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8274022
>> Simplified code related to WeakHashMaps
>
> modules/javafx.controls/src/main/java/com/sun/javafx/sc
> This fixes the new ControlAcceleratorBug which was Introduced in JavaFX17.
> To fix it, I've made the Value of the WeakHashMap also weak.
> We only keep this value to remove it as a listener later on. Therefore there
> shouldn't be issues by making this value weak.
>
>
> I've seen this Bug ve
> This fixes the new ControlAcceleratorBug which was Introduced in JavaFX17.
> To fix it, I've made the Value of the WeakHashMap also weak.
> We only keep this value to remove it as a listener later on. Therefore there
> shouldn't be issues by making this value weak.
>
>
> I've seen this Bug ve
On Fri, 12 Nov 2021 23:42:30 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8274022
>> Simplified code related to WeakHashMaps
>
> modules/javafx.controls/src/main/java/com/sun/javafx/sc
> When using Swing it's possible to generate a Deadlock.
> It's related to the nested eventloop started in enterFullScreenExitingLoop -
> and the RenderLock aquired when using setView in Scene.
> Sample Programm and Threaddump are added to the ticket.
>
> Removing the nested loop fixes the Prob
On Mon, 18 Oct 2021 08:20:22 GMT, Florian Kirmaier
wrote:
>> When using Swing it's possible to generate a Deadlock.
>> It's related to the nested eventloop started in enterFullScreenExitingLoop
>> - and the RenderLock aquired when using setView in Scene.
>> Sample Programm and Threaddump are
This PR fixes an exception that can happen when dragging an image from a
WebView on macOS.
Dragging an image that is directly included like ``
works fine, without exception. However, there are (at least) two other cases
when the IAE is thrown:
- Dragging an image that is part of an hyperlink,
> Cleanup of Tree-/TableRowSkin to support switching skins
>
> The misbehavior/s
> - memory leaks due to manually registered listeners that were not removed
> - side-effects due to listeners still active on old skin (like NPEs)
>
> Fix
> - use skin api for all listener registration (for automatic
On Tue, 5 Oct 2021 20:36:37 GMT, Martin Fox wrote:
> The test case for JDK-8160241 creates a window in a zoomed state (as defined
> by macOS). When the OS later goes to unzoom the window it will try to shrink
> it down to 1 point wide. This was entered as JDK-8163137 but the fix for that
> bug
On Mon, 1 Nov 2021 12:59:42 GMT, Marius Hanl wrote:
>> well .. that would be a merge conflict, had you updated the code comment in
>> your PR 😁 As noted in my comments to Ajit's review, the listener
>> registration is simply moved (including the code comment .. belatedly :)
>>
>> Not sure how
On Mon, 15 Nov 2021 08:24:04 GMT, Florian Kirmaier
wrote:
>> This fixes the new ControlAcceleratorBug which was Introduced in JavaFX17.
>> To fix it, I've made the Value of the WeakHashMap also weak.
>> We only keep this value to remove it as a listener later on. Therefore there
>> shouldn't b
On Mon, 15 Nov 2021 08:24:04 GMT, Florian Kirmaier
wrote:
>> This fixes the new ControlAcceleratorBug which was Introduced in JavaFX17.
>> To fix it, I've made the Value of the WeakHashMap also weak.
>> We only keep this value to remove it as a listener later on. Therefore there
>> shouldn't b
When a divider is moved via drag or code it will call **requestLayout()** for
the **SplitPane**.
While this is fine, it is also called when the **layoutChildren(..)** method is
repositioning the divider.
This makes no sense since we are currently layouting everything, so we don't
need to reques
On Tue, 2 Nov 2021 09:41:09 GMT, Michael Strauß wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8274022
>> Simplified code related to WeakHashMaps
>
> Marked as reviewed by mstrauss (Author).
@mstr2 can you
On Mon, 15 Nov 2021 08:24:04 GMT, Florian Kirmaier
wrote:
>> This fixes the new ControlAcceleratorBug which was Introduced in JavaFX17.
>> To fix it, I've made the Value of the WeakHashMap also weak.
>> We only keep this value to remove it as a listener later on. Therefore there
>> shouldn't b
On Sat, 30 Oct 2021 10:56:40 GMT, Florian Kirmaier
wrote:
> This fixes the new ControlAcceleratorBug which was Introduced in JavaFX17.
> To fix it, I've made the Value of the WeakHashMap also weak.
> We only keep this value to remove it as a listener later on. Therefore there
> shouldn't be is
On Fri, 22 Oct 2021 17:32:10 GMT, Martin Fox wrote:
> During a drag-and-drop operation on the Mac the Command key will filter out
> every drag source operation except `NSDragOperationGeneric` (this behavior is
> provided by the OS). JavaFX drag sources only set the Move, Copy, and Link
> drag
On Thu, 11 Nov 2021 15:18:25 GMT, Kevin Rushforth wrote:
> I left a few comments on the dependencies. Will review / test the PR later.
>
> One comment about adding new JUnit 5 tests and migrating existing tests. I
> think there could be value in organizing the tests such that all of the JUnit
This bumps the version of gradle used to build JavaFX to 7.3 (from the current
7.0.1). Among other things, gradle 7.3 adds support for JDK 17, so this is a
prerequisite to update the boot JDK to JDK 17.x -- see
[JDK-8276144](https://bugs.openjdk.java.net/browse/JDK-8276144). This will not
affec
Clean backport to `jfx17u`.
-
Commit messages:
- 8274022: Additional Memory Leak in ControlAcceleratorSupport
Changes: https://git.openjdk.java.net/jfx17u/pull/21/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u&pr=21&range=00
Issue: https://bugs.openjdk.java.net/brows
On Mon, 15 Nov 2021 18:48:51 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx17u`.
This pull request has now been integrated.
Changeset: e3b061c9
Author:Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx17u/commit/e3b061c9d3667bd7ec327d9c9869d6415fd33414
Stats: 46 lines i
The code that maps from a Windows virtual key code to a Java key code in
`getKeyCodeForChar` did not match the similar code in
`ViewContainer::HandleViewKeyEvent`. The OEM keys are assigned to printable
punctuation and symbols in way which varies across layouts and even keyboards.
To determine
On Mon, 15 Nov 2021 16:42:04 GMT, Michael Strauß wrote:
> One comment about adding new JUnit 5 tests and migrating existing tests. I
> think there could be value in organizing the tests such that all of the JUnit
> 5 tests are grouped, rather than mixing tests in the same directory such that
>
On Sat, 25 Sep 2021 13:55:15 GMT, John Hendrikx wrote:
>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
>> still work. Also added a single JUnit 5 tests, and confirmed it works.
>>
>> I've updated the Eclipse project file for the base module only.
>
> John Hendri
On Thu, 11 Nov 2021 15:11:32 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Readd junit declaration in allprojects and set junit version to 4.13.2
>
> build.gradle line 1953:
>
>> 1951:
On Fri, 24 Sep 2021 20:45:23 GMT, Kevin Rushforth wrote:
> As mentioned in JBS, any new third-party libraries require prior third-party
> license approval. And we will need to work with you on sponsoring this (as
> you can't contribute any third-party code under the OCA).
>
> Speaking of which
> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
> still work. Also added a single JUnit 5 tests, and confirmed it works.
>
> I've updated the Eclipse project file for the base module only.
John Hendrikx has updated the pull request incrementally with two additiona
> - Added support for H.265/HEVC for all 3 platforms.
> - Support is added only for .mp4 files over FILE/HTTP/HTTPS protocols. HTTP
> Live Streaming with H.265/HEVC is not supported.
> - On Windows mfwrapper was introduced which uses Media Foundation APIs to
> decode HEVC.
> - 10 and 12-bit HE
On Tue, 16 Nov 2021 02:24:11 GMT, Alexander Matveev
wrote:
>> - Added support for H.265/HEVC for all 3 platforms.
>> - Support is added only for .mp4 files over FILE/HTTP/HTTPS protocols. HTTP
>> Live Streaming with H.265/HEVC is not supported.
>> - On Windows mfwrapper was introduced which u
29 matches
Mail list logo
