Re: Glass Robot and getSCreenCapture

2014-03-26 Thread Stas Smirnov
Hi David, sorry to keep you waiting with an answer from Embedded SQE. I assume there will be no major impact on SQE since as you told and it is true, most golden image tests we have are based on a window content. Anyway from what I understood your implementation will be easily rolled back if we

Re: Adding GStreamer plugins

2014-03-26 Thread Michael Berry
Unfortunately I seem to have become a bit stuck at step one! I'm probably missing a few things that are rather obvious, but haven't really got much experience at all in this area, so am relying on haphazard Googling and a bit of guesswork! It may well be that updating the framework is a bit beyond

hg: openjfx/8u-dev/rt: 2 new changesets

2014-03-26 Thread hang . vo
Changeset: 335ad99f854f Author:kcr Date: 2014-03-26 14:40 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/335ad99f854f RT-35019: [3D] NPE in NGShape.renderContent when drawing empty shapes Reviewed-by: flar ! modules/graphics/src/main/java/com/sun/javafx/sg/prism/NGShap

hg: openjfx/8u-dev/rt: 2 new changesets

2014-03-26 Thread hang . vo
Changeset: bd741e03a5d2 Author:jgiles Date: 2014-03-27 09:16 +1300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/bd741e03a5d2 RT-36392: [SplitPane] Cannot lookup children inside a SplitPane ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/SplitPaneSkin.ja

hg: openjfx/2u/dev/rt: Added tag 2.2.60-b12 for changeset c1541c2d6a96

2014-03-26 Thread hang . vo
Changeset: ad9fa39517da Author:hudson Date: 2014-03-26 08:12 -0700 URL: http://hg.openjdk.java.net/openjfx/2u/dev/rt/rev/ad9fa39517da Added tag 2.2.60-b12 for changeset c1541c2d6a96 ! .hgtags

Re: Glass Robot and getSCreenCapture

2014-03-26 Thread David DeHaven
> For a one shot screen capture - we would pass in top left and width and > height to make the bottom right. > Currently this should work on Mac I am told, though what is in the out of > bounds pixels is not known. > And if we added a third "tall" screen to the left, life gets even more > compl

Re: Glass Robot and getSCreenCapture

2014-03-26 Thread David Hill
On 3/26/14, Mar 26, 12:53 PM, Stephen F Northover wrote: I don't like "implied" contract code either but I also don't like exceptions for cases like this. I would prefer that we return zero for pixels that are unspecified as this seems better than testing screen bounds (which can get you in tr

[8u Review Request] RT-35864: Button's events are not working in a ListView

2014-03-26 Thread David Grieve
Jonathan, Please review: http://cr.openjdk.java.net/~dgrieve/RT-35864/webrev.00 A summary of the changes is in: https://javafx-jira.kenai.com/browse/RT-35864

hg: openjfx/8u-dev/rt: 2 new changesets

2014-03-26 Thread hang . vo
Changeset: 91fdf1709eae Author:hudson Date: 2014-03-26 11:23 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/91fdf1709eae Added tag 8u20-b07 for changeset eee373287ad8 ! .hgtags Changeset: 5f8012b58540 Author:kcr Date: 2014-03-26 11:35 -0700 URL: http://

hg: openjfx/8u-dev/rt: RT-31075: Date picker fails with LocalDate.MAX and LocalDate.MIN values.

2014-03-26 Thread hang . vo
Changeset: 0f1a42edda54 Author:leifs Date: 2014-03-26 10:11 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/0f1a42edda54 RT-31075: Date picker fails with LocalDate.MAX and LocalDate.MIN values. ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/DatePick

[8u6] Review request: RT-36387: [IMX, Lens] Black rectangle seen instead of cursor on first run after reboot

2014-03-26 Thread Lisa Selle
Daniel, Rafi, Please review the simple fix for https://javafx-jira.kenai.com/browse/RT-36387 - [IMX, Lens] Black rectangle seen instead of cursor on first run after reboot Diff is in the jira. Thanks, Lisa

Re: Glass Robot and getSCreenCapture

2014-03-26 Thread Stephen F Northover
On 2014-03-26 12:22 PM, David Hill wrote: On 3/26/14, Mar 26, 10:59 AM, Stephen F Northover wrote: Hi David, Sorry to be getting to this so late. An uninitialized pixel is normally considered to be black. If you throw an exception, clients will need to either catch the exception or perform

Re: Glass Robot and getSCreenCapture

2014-03-26 Thread David Hill
On 3/26/14, Mar 26, 10:59 AM, Stephen F Northover wrote: Hi David, Sorry to be getting to this so late. An uninitialized pixel is normally considered to be black. If you throw an exception, clients will need to either catch the exception or perform the same test that you are performing befor

Re: Glass Robot and getSCreenCapture

2014-03-26 Thread Scott Palmer
It isn't public API now.. but keep in mind that making it public in some way has been requested for over two years. See RT-17571 Since those issues have made the internal Robot API known, no doubt people are using it. (We all know how well people listen to the warnings about using internal APIs ..

Re: Glass Robot and getSCreenCapture

2014-03-26 Thread Stephen F Northover
Hi David, Sorry to be getting to this so late. An uninitialized pixel is normally considered to be black. If you throw an exception, clients will need to either catch the exception or perform the same test that you are performing before they call the "API". Since this is not pubic API, no

Monadic operations on ObservableValue

2014-03-26 Thread Tomas Mikula
EasyBind [1] now adds monadic operations on ObservableValue: http://tomasmikula.github.io/blog/2014/03/26/monadic-operations-on-observablevalue.html [1] http://www.fxmisc.org/easybind/

Re: file attachment in Jira

2014-03-26 Thread Stephen F Northover
I'm so sorry about this. This is a silly and draconian restriction that most open source projects do not face. I have pinged the Mordac-like elements that govern us once more, however, I have no direct control over the outcome. Steve On 2014-03-26 9:22 AM, Pedro Duque Vieira wrote: Hi, I

Re: Adding GStreamer plugins

2014-03-26 Thread Kirill Kirichenko
I added a wiki link: https://wiki.openjdk.java.net/pages/viewpage.action?pageId=18808963 I welcome free will participants to go over the steps, upgrade GStreamer and eventually create a precise version of the guide. I will provide as much help as I can. K On 26.03.2014 16:43, Kirill Kirichen

file attachment in Jira

2014-03-26 Thread Pedro Duque Vieira
Hi, I know this has been discussed before, in one instance it was said file attachment in jira would not be possible due to internal possibles, later it was said this should be possible and would be dealt with. I think it would be important for this to be possible given the highly collaborative n

Re: Adding GStreamer plugins

2014-03-26 Thread Stephen F Northover
https://javafx-jira.kenai.com/browse/RT-18009 This JIRA is covering adding support for more media formats. Since we are just talking about MKV, please open a separate JIRA to cover this work and attach the patch there. We can link to the new JIRA from RT-18009. Steve On 2014-03-25 7:47 PM,

Re: Adding GStreamer plugins

2014-03-26 Thread Kirill Kirichenko
Michael, On 26.03.2014 04:11, Michael Berry wrote: Kirill - I think I'll take your suggestion next and start looking at upgrading the existing native components to the latest version of GStreamer before I look at adding any more plugins, that would seem to make sense. Have you any pointers in ho

Re: Adding GStreamer plugins

2014-03-26 Thread Kirill Kirichenko
There is another issue with new plugins. We have thoroughly tested with a closed source internal test suite on all platforms every plugin that we already have. If we add something new this may open a way for crashes, security breaches. So if you add something new and want this to be included in

hg: openjfx/8u-dev/rt: RT-35263: Win: Crashing VM in a JavaFX 3D app reading and writing STL files

2014-03-26 Thread hang . vo
Changeset: 89ca2db487e3 Author:Anthony Petrov Date: 2014-03-26 15:13 +0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/89ca2db487e3 RT-35263: Win: Crashing VM in a JavaFX 3D app reading and writing STL files Summary: Check if the window is still alive after handling a syn

Re: Adding GStreamer plugins

2014-03-26 Thread Michael Berry
Hi David, Sure - I'm aware there's legal issues surrounding many of the formats, though one of the reasons I picked MKV to start with was because it's an open container format. I'm certainly not aware of any restrictions surrounding it (though please correct me if I'm wrong on that front!) A swit

hg: openjfx/8u-dev/rt: RT-36371 GridPane ColumnConstraints Java 7 and 8 broken compatibility

2014-03-26 Thread hang . vo
Changeset: 14580ce9a75e Author:Martin Sladecek Date: 2014-03-26 09:39 +0100 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/14580ce9a75e RT-36371 GridPane ColumnConstraints Java 7 and 8 broken compatibility ! modules/graphics/src/main/java/javafx/scene/layout/GridPane.java !

Re: Glass Robot and getSCreenCapture

2014-03-26 Thread Jack Moxley
It should be throwing an exception or returning null, returning a real value is a code smell. Sent from my iPhone > On 23 Mar 2014, at 07:55, Daniel Blaukopf wrote: > > We should be consistent about what we return, although I agree that that the > actual value doesn’t seem to matter. 0 for im