Re: Subject: JavaFX dependency injection

Hi, This is not a new subject and I guess we already received answers in the past on this list: JavaFX team does not provide any DI mechanism just like core java teams do not provide any DI on java-se. What is provided is "only" the possibility to hook controller factory (which allows already a

Re: TableCell.getTableRow() return value

It was an oversight at the time, and (from memory) is now a breaking change to fix it, so for now it remains as it is, sadly. -- Jonathan Sent from a touch device. Please excuse my brevity. On 26 November 2015 03:33:04 GMT+13:00, Lawrence Parker wrote: >Seems like

Bulk packager integration

Kevin, Chris, Dmitry This is a bulk packager integration from the packager sandbox to the JavaFX Sandbox, please review. webrev: There are three changes outside of the fxpackager module that I think Kevin needs to give his approval for. Two changes are in the build.gradle. The first adds a

Re: Bulk packager integration

Here's the webrev: http://cr.openjdk.java.net/~shemnon/8080531/webrev.07/ (it's been a stressful morning) > On Nov 25, 2015, at 9:38 AM, Danno Ferrin wrote: > > Kevin, Chris, Dmitry > > This is a bulk packager

[9, 8u] review request: [JAVADOC] Change docs to not refer to full-screen exclusive mode

David, Please review this simple doc fix. https://bugs.openjdk.java.net/browse/JDK-8089847 http://cr.openjdk.java.net/~kcr/8089847/webrev.00/ Thanks. -- Kevin

Re: TableCell.getTableRow() return value

You should be able to add generics compatibly, you just can't change the generics signature. One shot to get it right IIRC. > On Nov 25, 2015, at 8:57 AM, Jonathan Giles wrote: > > It was an oversight at the time, and (from memory) is now a breaking change > to fix

Re: Bulk packager integration

1) I get the following error if I apply the patch and do a build: :fxpackager:compileJava/localhome/kcr/javafx/9-jake-kcr/jfx/rt/modules/fxpackager/src/main/java/com/oracle/tools/packager/JLinkBundlerHelper.java:3: error: package com.sun.tools.jdeps does not exist import

Re: TableCell.getTableRow() return value

Sounds good. Thanks, Jonathan (and Richard for pointing this out). -- Kevin Jonathan Giles wrote: I think in this situation you're right - I just made the change locally and did a full build of the SDK and all apps, and everything compiles. My Jira-foo is not strong enough to find the issue

Fwd: Subject: JavaFX dependency injection

+ mailgroup I dont think its non-standard. We have solved this by creating a factory that holds the bean id (and does a lookup when callback is invoked). Alternatively, to make the solution Spring-free, the factory can hold the controller object. Both these approaches work, but seem like a work

Re: TableCell.getTableRow() return value

Sounds good, thank you very much!! -Larry > On Nov 25, 2015, at 3:37 PM, Jonathan Giles wrote: > > I think in this situation you're right - I just made the change locally and > did a full build of the SDK and all apps, and everything compiles. My > Jira-foo is not

Re: TableCell.getTableRow() return value

I have filed and attached the issue here: https://bugs.openjdk.java.net/browse/JDK-8144088 @Kevin - would you mind giving this a quick API review please? -- Jonathan On 26/11/15 10:00 AM, Jonathan Giles wrote: I found the Jira issue I was looking forunfortunately it lacks a lot of detail.

Re: TableCell.getTableRow() return value

Looks good to me. I also added a comment to the bug report. -- Kevin Jonathan Giles wrote: I have filed and attached the issue here: https://bugs.openjdk.java.net/browse/JDK-8144088 @Kevin - would you mind giving this a quick API review please? -- Jonathan On 26/11/15 10:00 AM, Jonathan

Re: TableCell.getTableRow() return value

I think in this situation you're right - I just made the change locally and did a full build of the SDK and all apps, and everything compiles. My Jira-foo is not strong enough to find the issue I'm thinking of, but I do recall an issue in one place in the TableView API about generics being

[9] Review request for 8139841: Axis class does not render ticks marks when tick labels are invisible

Jonathan, Please review the fix: https://bugs.openjdk.java.net/browse/JDK-8139841 http://cr.openjdk.java.net/~vadim/8139841/webrev.00/ Thanks, Vadim