Re: [8u, 9] Review request: 8145516: Scene content shows too large on Retina display, when a regular screen attached

[Jim Graham]

Updating the subject line to request 8u backport approval.  The fix applies 
cleanly to 8u and fixes the bug there as well...

...jim

On 6/17/16 2:09 PM, Jim Graham wrote:

bug: https://bugs.openjdk.java.net/browse/JDK-8145516
webrev: http://cr.openjdk.java.net/~flar/JDK-8145516/webrev.00/

Information on the fix is in the bug report comments.

I need to repair my 8u-dev repos to check, but I believe this can be ported 
directly to an 8u release...

...jim

[9] Code Review Request For 8157500: Create unit tests for new public methods in GridPane

[Chien Yang]

Hi Kevin,

Please review the proposed unit test:

JIRA: https://bugs.openjdk.java.net/browse/JDK-8157500
Webev: http://cr.openjdk.java.net/~ckyang/JDK-8157500/webrev.00/

Thanks,
- Chien

[9] Review request: 8145516: Scene content shows too large on Retina display, when a regular screen attached

[Jim Graham]

bug: https://bugs.openjdk.java.net/browse/JDK-8145516
webrev: http://cr.openjdk.java.net/~flar/JDK-8145516/webrev.00/

Information on the fix is in the bug report comments.

I need to repair my 8u-dev repos to check, but I believe this can be ported 
directly to an 8u release...

...jim

RE: Building OpenJFX for the first time

[John C. Turnbull]

Thanks Kevin - that looks very helpful.

-Original Message-
From: openjfx-dev [mailto:openjfx-dev-boun...@openjdk.java.net] On Behalf Of
Kevin Rushforth
Sent: Saturday, 18 June 2016 05:53
To: openjfx-dev@openjdk.java.net
Subject: Re: Building OpenJFX for the first time

https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX

Dave Hill updated it recently, so it is reasonably current.

-- Kevin


John C. Turnbull wrote:
> I would like to set up a development environment for the OpenJFX 
> project but have never attempted this before.
>
>  
>
> I am very familiar with all 3 major Java IDEs with my preference (in 
> order of most favourite to least favourite) is Eclipse, IntelliJ, 
> NetBeans (so whichever one is "best" doesn't really matter).
>
>  
>
> I am familiar with Gradle but by no means an expert.
>
>  
>
> My machine is a Windows 10 x64 PC.
>
>  
>
> I am only interested in building for JDK 9 and JavaFX 9 (as these will 
> be released before any project I am working on will go live).
>
>  
>
> I am happy to build just for Windows at this point so I can get a feel 
> for the project and see if there are opportunities where I can fix a 
> bug or two or make contributions in other ways.
>
>  
>
> So, what is the best way to build this project using the environment 
> and tools I have described?
>
>  
>
> Which IDE would make the process the simplest or easiest?
>
>  
>
> Is there an up-to-date web page that describes the process in 
> sufficient detail that will enable me to accomplish this?
>
>  
>
> Thanks very much,
>
>  
>
> John
>
>  
>
>   

Re: Building OpenJFX for the first time

[Kevin Rushforth]

https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX

Dave Hill updated it recently, so it is reasonably current.

-- Kevin


John C. Turnbull wrote:

I would like to set up a development environment for the OpenJFX project but
have never attempted this before.

 


I am very familiar with all 3 major Java IDEs with my preference (in order
of most favourite to least favourite) is Eclipse, IntelliJ, NetBeans (so
whichever one is "best" doesn't really matter).

 


I am familiar with Gradle but by no means an expert.

 


My machine is a Windows 10 x64 PC.

 


I am only interested in building for JDK 9 and JavaFX 9 (as these will be
released before any project I am working on will go live).

 


I am happy to build just for Windows at this point so I can get a feel for
the project and see if there are opportunities where I can fix a bug or two
or make contributions in other ways.

 


So, what is the best way to build this project using the environment and
tools I have described?

 


Which IDE would make the process the simplest or easiest?

 


Is there an up-to-date web page that describes the process in sufficient
detail that will enable me to accomplish this?

 


Thanks very much,

 


John

 

  

Re: LocalDateTimeStringConverterTest seem to fail if default locale is different to en_US

[Kevin Rushforth]

It seems like the test is not written to handle multiple Locales, so if 
you could file a bug, we'll fix it (I note that it could probably be in 
a "BeforeClass" block as one-time setup rather than setting it before 
each test).


As for your other test failures, I presume you are using FX 9-dev? Are 
you running in "legacy" mode (building and testing with jdk-9+109 with 
no JIGSAW_HOME being set)? If so, I haven't seen that error before. We 
continuously run tests in this mode with no failures. Did you remove 
(and not just rename) jfxrt.jar from your jdk-9 boot JDK?


-- Kevin


Alexander Nyssen wrote:

Hi,

I could resolve this by changing the setup method of 
LocalDateTimeStringConverterTest to the following:

@Before public void setup() {
// tests require that default locale is English
Locale.setDefault(Locale.ENGLISH);
}
Maybe that should be added to make it robust.

Unfortunately, I am now stuck, because the succeeding controls tests fail, as 
it seems all with the following NoClassDefFoundError:

test.javafx.scene.control.TreeViewTest > test_rt_31200_tableRow FAILED
java.lang.NoClassDefFoundError: javafx.scene.control.Control
at test.javafx.scene.control.TreeViewTest.setup(TreeViewTest.java:121)

7133 tests completed, 6326 failed, 239 skipped
:controls:test FAILED

FAILURE: Build failed with an exception.

The build succeeded (using gradle). Any idea what might be wrong? 


Regards,
Alexander

  

Am 17.06.2016 um 07:56 schrieb Alexander Nyssen :

Hi,

in order to be able to contribute to OpenJFX, I am currently trying to set up my 
development environment. After checking out the latest head from hg clone 
http://hg.openjdk.java.net/openjfx/9-dev/rt 
, compilation succeeds, but tests 
fail with the following:

test.javafx.util.converter.LocalDateTimeStringConverterTest > 
converter_with_specified_formatter_and_parser[0] FAILED
org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
was:<12 Januar[] 1985, 12:34:56>
at org.junit.Assert.assertEquals(Assert.java:123)
at org.junit.Assert.assertEquals(Assert.java:145)
at 
test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_parser(LocalDateTimeStringConverterTest.java:144)

test.javafx.util.converter.LocalDateTimeStringConverterTest > 
converter_with_specified_formatter_and_null_parser[0] FAILED
org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
was:<12 Januar[] 1985, 12:34:56>
at org.junit.Assert.assertEquals(Assert.java:123)
at org.junit.Assert.assertEquals(Assert.java:145)
at 
test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_null_parser(LocalDateTimeStringConverterTest.java:152)

test.javafx.util.converter.LocalDateTimeStringConverterTest > 
converter_with_specified_formatter_and_parser[1] FAILED
org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
was:<12 Januar[] 1985, 12:34:56>
at org.junit.Assert.assertEquals(Assert.java:123)
at org.junit.Assert.assertEquals(Assert.java:145)
at 
test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_parser(LocalDateTimeStringConverterTest.java:144)

test.javafx.util.converter.LocalDateTimeStringConverterTest > 
converter_with_specified_formatter_and_null_parser[1] FAILED
org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
was:<12 Januar[] 1985, 12:34:56>
at org.junit.Assert.assertEquals(Assert.java:123)
at org.junit.Assert.assertEquals(Assert.java:145)
at 
test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_null_parser(LocalDateTimeStringConverterTest.java:152)

test.javafx.util.converter.LocalDateTimeStringConverterTest > 
converter_with_specified_formatter_and_parser[2] FAILED
org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
was:<12 Januar[] 1985, 12:34:56>
at org.junit.Assert.assertEquals(Assert.java:123)
at org.junit.Assert.assertEquals(Assert.java:145)
at 
test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_parser(LocalDateTimeStringConverterTest.java:144)

test.javafx.util.converter.LocalDateTimeStringConverterTest > 
converter_with_specified_formatter_and_null_parser[2] FAILED
org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
was:<12 Januar[] 1985, 12:34:56>
at org.junit.Assert.assertEquals(Assert.java:123)
at org.junit.Assert.assertEquals(Assert.java:145)
at 
test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_null_parser(LocalDateTimeStringConverterTest.java:152)

It seems they are not robust against having a default locale different to en_US 
(Januar is the correct German tra

Re: JavaFX 9 & FXCanvas

[dalibor topic]

On 15.06.2016 07:36, Alexander Nyßen wrote:

Would it require he (as well as all GEF committers that worked on the mentioned 
fixes) would have to sign the OCA as well?


If there are multiple authors to a contribution, then they all need to 
have an OCA on file. If one or more contributions are done on behalf of 
an organization, such as a company, than that organization needs to have 
an OCA on file, as well. Details are discussed in the OCA FAQ, available 
at http://www.oracle.com/technetwork/oca-faq-405384.pdf .



Is there any experience on how to transfer EPL-licensed code already?


No.

Fwiw, I don't think that kind of transfer would work, in general. 
Contributions need to come in under OCA or an equivalent.


As a general aside, while I don't know how the specific code in question 
was authored by whom on whose behalf, putting in all the work necessary 
to unravel the history of third party code in order to understand who 
can contribute what, if anything, could be more work and more time 
consuming than coming up with a better & novel solution from scratch, if 
it's 'just' a couple of bug fixes.


cheers,
dalibor topic

--
 Dalibor Topic | Principal Product Manager
Phone: +494089091214  | Mobile: +491737185961


ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher

 Oracle is committed to developing
practices and products that help protect the environment

Re: PING: JDK-8146900: [SwingNode, DND]: drag-and-drop from JTable not working, drag recognized twice

[Kevin Rushforth]

I missed seeing this when you first posted it. I will add your comments 
to the bug report. Alexander Z may want to chime in since the bug is 
assigned to him and he is the component lead for SwingNode.


-- Kevin


Yasumasa Suenaga wrote:

PING: Have you ever read this proposal?

Yasumasa

On 2016/06/08 22:05, Yasumasa Suenaga wrote:

Hi all,

We are developing HeapStats [1] with JavaFX 8.
This tool uses SwingNode to use JGraphX [2].

JGraphX suports Drag & Drop. However, DnD in SwingNode occurs 
InvalidDnDOperationException.

Callstack of it is same with JDK-8146900.

I checked OpenJDK source, the flag of DnD is static field [3].
DnD event is trapped at FXDnD, and kick the same event via secondary 
event loop.
Thus DnD event will be called twice, and second event will be thrown 
InvalidDnDOperationException.



I think we can fix it as below.
However I'm not sure it is correct.

Could you help?

---
diff -r 20164b54e3d8 
modules/swing/src/main/java/javafx/embed/swing/FXDnD.java
--- a/modules/swing/src/main/java/javafx/embed/swing/FXDnD.java Wed 
Jun 08 13:34:10 2016 +1200
+++ b/modules/swing/src/main/java/javafx/embed/swing/FXDnD.java Wed 
Jun 08 22:02:10 2016 +0900

@@ -312,6 +312,10 @@
 // and then start an AWT nested loop to wait until DnD 
finishes.
 loop = 
java.awt.Toolkit.getDefaultToolkit().getSystemEventQueue().createSecondaryLoop(); 


 SwingFXUtils.leaveFXNestedLoop(FXDnD.this);
+
+// Avoid JDK-8146900
+setDragDropInProgress(false);
+
 if (!loop.enter()) {
 // An error occured, but there's little we can do 
here...

 }
---


Thanks,

Yasumasa


[1] http://icedtea.classpath.org/wiki/HeapStats
[2] https://github.com/jgraph/jgraphx
[3] 
http://hg.openjdk.java.net/jdk9/dev/jdk/file/4f717d517d9e/src/java.desktop/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java#l77 

Re: LocalDateTimeStringConverterTest seem to fail if default locale is different to en_US

[Alexander Nyssen]

Hi,

I could resolve this by changing the setup method of 
LocalDateTimeStringConverterTest to the following:

@Before public void setup() {
// tests require that default locale is English
Locale.setDefault(Locale.ENGLISH);
}
Maybe that should be added to make it robust.

Unfortunately, I am now stuck, because the succeeding controls tests fail, as 
it seems all with the following NoClassDefFoundError:

test.javafx.scene.control.TreeViewTest > test_rt_31200_tableRow FAILED
java.lang.NoClassDefFoundError: javafx.scene.control.Control
at test.javafx.scene.control.TreeViewTest.setup(TreeViewTest.java:121)

7133 tests completed, 6326 failed, 239 skipped
:controls:test FAILED

FAILURE: Build failed with an exception.

The build succeeded (using gradle). Any idea what might be wrong? 

Regards,
Alexander

> Am 17.06.2016 um 07:56 schrieb Alexander Nyssen :
> 
> Hi,
> 
> in order to be able to contribute to OpenJFX, I am currently trying to set up 
> my development environment. After checking out the latest head from hg clone 
> http://hg.openjdk.java.net/openjfx/9-dev/rt 
> , compilation succeeds, but 
> tests fail with the following:
> 
> test.javafx.util.converter.LocalDateTimeStringConverterTest > 
> converter_with_specified_formatter_and_parser[0] FAILED
> org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
> was:<12 Januar[] 1985, 12:34:56>
> at org.junit.Assert.assertEquals(Assert.java:123)
> at org.junit.Assert.assertEquals(Assert.java:145)
> at 
> test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_parser(LocalDateTimeStringConverterTest.java:144)
> 
> test.javafx.util.converter.LocalDateTimeStringConverterTest > 
> converter_with_specified_formatter_and_null_parser[0] FAILED
> org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
> was:<12 Januar[] 1985, 12:34:56>
> at org.junit.Assert.assertEquals(Assert.java:123)
> at org.junit.Assert.assertEquals(Assert.java:145)
> at 
> test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_null_parser(LocalDateTimeStringConverterTest.java:152)
> 
> test.javafx.util.converter.LocalDateTimeStringConverterTest > 
> converter_with_specified_formatter_and_parser[1] FAILED
> org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
> was:<12 Januar[] 1985, 12:34:56>
> at org.junit.Assert.assertEquals(Assert.java:123)
> at org.junit.Assert.assertEquals(Assert.java:145)
> at 
> test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_parser(LocalDateTimeStringConverterTest.java:144)
> 
> test.javafx.util.converter.LocalDateTimeStringConverterTest > 
> converter_with_specified_formatter_and_null_parser[1] FAILED
> org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
> was:<12 Januar[] 1985, 12:34:56>
> at org.junit.Assert.assertEquals(Assert.java:123)
> at org.junit.Assert.assertEquals(Assert.java:145)
> at 
> test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_null_parser(LocalDateTimeStringConverterTest.java:152)
> 
> test.javafx.util.converter.LocalDateTimeStringConverterTest > 
> converter_with_specified_formatter_and_parser[2] FAILED
> org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
> was:<12 Januar[] 1985, 12:34:56>
> at org.junit.Assert.assertEquals(Assert.java:123)
> at org.junit.Assert.assertEquals(Assert.java:145)
> at 
> test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_parser(LocalDateTimeStringConverterTest.java:144)
> 
> test.javafx.util.converter.LocalDateTimeStringConverterTest > 
> converter_with_specified_formatter_and_null_parser[2] FAILED
> org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
> was:<12 Januar[] 1985, 12:34:56>
> at org.junit.Assert.assertEquals(Assert.java:123)
> at org.junit.Assert.assertEquals(Assert.java:145)
> at 
> test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_null_parser(LocalDateTimeStringConverterTest.java:152)
> 
> It seems they are not robust against having a default locale different to 
> en_US (Januar is the correct German translation for January; my default 
> locale seems to be de_DE).
> 
> Regards,
> Alexander
> 

PING: JDK-8146900: [SwingNode, DND]: drag-and-drop from JTable not working, drag recognized twice

[Yasumasa Suenaga]

PING: Have you ever read this proposal?

Yasumasa

On 2016/06/08 22:05, Yasumasa Suenaga wrote:

Hi all,

We are developing HeapStats [1] with JavaFX 8.
This tool uses SwingNode to use JGraphX [2].

JGraphX suports Drag & Drop. However, DnD in SwingNode occurs 
InvalidDnDOperationException.
Callstack of it is same with JDK-8146900.

I checked OpenJDK source, the flag of DnD is static field [3].
DnD event is trapped at FXDnD, and kick the same event via secondary event loop.
Thus DnD event will be called twice, and second event will be thrown 
InvalidDnDOperationException.


I think we can fix it as below.
However I'm not sure it is correct.

Could you help?

---
diff -r 20164b54e3d8 modules/swing/src/main/java/javafx/embed/swing/FXDnD.java
--- a/modules/swing/src/main/java/javafx/embed/swing/FXDnD.java Wed Jun 08 
13:34:10 2016 +1200
+++ b/modules/swing/src/main/java/javafx/embed/swing/FXDnD.java Wed Jun 08 
22:02:10 2016 +0900
@@ -312,6 +312,10 @@
 // and then start an AWT nested loop to wait until DnD finishes.
 loop = 
java.awt.Toolkit.getDefaultToolkit().getSystemEventQueue().createSecondaryLoop();
 SwingFXUtils.leaveFXNestedLoop(FXDnD.this);
+
+// Avoid JDK-8146900
+setDragDropInProgress(false);
+
 if (!loop.enter()) {
 // An error occured, but there's little we can do here...
 }
---


Thanks,

Yasumasa


[1] http://icedtea.classpath.org/wiki/HeapStats
[2] https://github.com/jgraph/jgraphx
[3] 
http://hg.openjdk.java.net/jdk9/dev/jdk/file/4f717d517d9e/src/java.desktop/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java#l77

[9] Review Request: 8159614: Can't get file size with javascript

[Ankit Srivastava]

Hi Arun, Murali & Kevin,

 

 

Please review the webrev.

 

JBS:  https://bugs.openjdk.java.net/browse/JDK-8159614

WebRev:  http://cr.openjdk.java.net/~asrivastava/8159614/webrev.00/

 

Solution updated in JBS.

 

 

Regards,

Ankit