[9] Code Review Request For 8164141: [Javadoc] Replace references of Stage with Window in the Window class

Hi Kevin, Please review the proposed doc fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8164141 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8164141/webrev.00/ Thanks, - Chien

Re: Exception running FXMark with JavaFX 9

On 16.08.2016 07:50, Felix Bembrick wrote: How do I access PerformanceTracker in Java/JavaFX 9? Please see http://openjdk.java.net/jeps/261 cheers, dalibor topic -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deut

Exception running FXMark with JavaFX 9

I am trying to port FXMark from Java 8 to Java 9 but encounter this exception: Caused by: java.lang.IllegalAccessError: class com.bembrick.fxmark.HUD (in unnamed module @0x59223fd5) cannot access class com.sun.javafx.perf.PerformanceTracker (in module javafx.graphics) because module javafx.graphic

Re: [PATCH] 8161282: FXCanvas does not forward horizontal mouse scroll events to the embedded scene

Hi Alexander, The fix looks good to me, except the wild card import change in FXCanvas.java(there is no need for a new patch, if it is the only issue found) On 8/16/16 10:24 AM, Alexander Nyssen wrote: You might even take the one I attached. I just recognized I still had some unused import

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

Looks fine to me too. On 8/16/16 1:45 AM, Kevin Rushforth wrote: The 2016-08-12 revision looks fine to me, except for a missing space as noted in JBS (no need for a new patch if that is the only issue found). While we wait for approval from the JDK 9 release team, we need another reviewer fo

Re: Marking synthesized scroll events as such.

Having started to work on JDK-8143596 today, I have to provide an update on this: those PAN gesture events that are emulated by SWT should indeed be ignored by FXCanvas (as done by our FXCanvasEX implementation), because: a) SCROLL gestures (ST

RE: Structuring CSS Stylesheets

Hi, > -Original Message- > From: Kevin Rushforth [mailto:kevin.rushfo...@oracle.com] > Sent: Monday, August 15, 2016 6:02 PM > To: David Grieve > Cc: Daniel Glöckner; openjfx-dev@openjdk.java.net > Subject: Re: Structuring CSS Stylesheets > > One slight correction on how to contribute bel

Re: [PATCH] 8161282: FXCanvas does not forward horizontal mouse scroll events to the embedded scene

You might even take the one I attached. I just recognized I still had some unused imports in the manual test case (I am still not familiar with IntelliJ). Regards, Alexander > Am 15.08.2016 um 19:26 schrieb Kevin Rushforth : > > OK, I'll upload this revised version of the patch today. > > --