Re: MarlinFX upgrade 0.7.5

2017-04-26 Thread Jim Graham 

Hi Laurent,

On 4/26/17 2:37 PM, Laurent Bourgès wrote:

I spotted at least one thing that I brought up in the 2D Marlin review, but 
since the 2 source bases are moving
towards synchronizing with each other I didn't look too closely since many 
of the changes in the 2D Marlin update
are things that are already "fixed" in this FX Marlin code, so I thought I 
would focus my scrutiny more on the 2D
review instead. Would this code base be affected by the review comments I 
made there?  Did you want to hold both
until they both are ready to go in and then push them at the same time (to 
keep them in sync)?

I really do not know how to push both patches at the same time as it points to 
different forrests ... (I only have
commit rights in graphics repo ?) Probably I let you push the final patches 
once ready and I will also maintain my
github branches in sync.


I wasn't talking about literally simultaneously, I was referring to waiting to push either until both have been reviewed 
and approved...


...jim

Re: MarlinFX upgrade 0.7.5

2017-04-26 Thread Laurent Bourgès 
Jim,


2017-04-26 7:06 GMT+02:00 Jim Graham :

> I've reviewed the code and run a number of tests.  Things look fine.
>

Thanks, but as I made some syntax changes in Marlin2D, I would like to
postpone the review and synchronize again the code with Marlin2D.


>
> I spotted at least one thing that I brought up in the 2D Marlin review,
> but since the 2 source bases are moving towards synchronizing with each
> other I didn't look too closely since many of the changes in the 2D Marlin
> update are things that are already "fixed" in this FX Marlin code, so I
> thought I would focus my scrutiny more on the 2D review instead. Would this
> code base be affected by the review comments I made there?  Did you want to
> hold both until they both are ready to go in and then push them at the same
> time (to keep them in sync)?
>

I really do not know how to push both patches at the same time as it points
to different forrests ... (I only have commit rights in graphics repo ?)
Probably I let you push the final patches once ready and I will also
maintain my github branches in sync.


>
> Minimally, it is time to file a bug against FX for this...
>
> ...jim
>
>
> On 4/19/17 11:35 PM, Laurent Bourgès wrote:
>
>> Hi,
>>
>> Please review this MarlinFX upgrade to Marlin 0.7.5:
>>
>> JBS: no bug yet for OpenJFX 10
>> webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-075.0/
>>
>> Changes:
>> - Renderers: fixed block processing
>> - dead code & few comment removals in Strokers
>> - fixed all floating-point number literals to be x.0f or x.0d to simplify
>> the conversion between float & double variants
>>
>> PS: I plan to run later FindBugs, Netbeans & IntelliJ code analysis tools
>> to fix any warning
>>
>> Cheers,
>> Laurent
>>
>>


-- 
-- 
Laurent Bourgès

[9] Code Review Request For 8179321: WebEngine.getDocument().getDocumentURI() no longer returns null for loading a String of HTML

2017-04-26 Thread Arunprasad Rajkumar 
Hi Kevin, Guru,

Please review the following fix,

JIRA: https://bugs.openjdk.java.net/browse/JDK-8179321 

Webrev: http://cr.openjdk.java.net/~arajkumar/8179321/webrev/ 


Thanks,
Arun

[9] Review request: 8179363 Errors in Redistributable Module List

2017-04-26 Thread Chris Bensen 
Kevin, Victor,

Please review this change to fix the redistributable file list.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8179363
Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8179363/webrev.00/

Chris