Re: RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

2017-08-28 Thread Jim Graham
Hi Laurent, On 8/28/17 2:09 PM, Laurent Bourgès wrote: Hi Jim, Thanks for your comments, it helped refining the webrev. Here are my answers: 2017-08-26 2:22 GMT+02:00 Jim Graham mailto:james.gra...@oracle.com>>: [D]Dasher.java - why the changes from (firstSegIdx > 0) to (firstSegIdx !=

Re: RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

2017-08-28 Thread Laurent Bourgès
Hi Jim, Thanks for your comments, it helped refining the webrev. Here are my answers: 2017-08-26 2:22 GMT+02:00 Jim Graham : > [D]Dasher.java - why the changes from (firstSegIdx > 0) to (firstSegIdx != > 0)? > As firstSegIdx is initialized to 0, I prefer testing (firstSegIdx != 0) as it looks

Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

2017-08-28 Thread Prasanta Sadhukhan
I have incorporated the logic to make sure the events are dispatched in sequence, ie if the event is not first in sequence, then it will made to wait till it is the first event or till it is disposed. Modified webrev http://cr.openjdk.java.net/~psadhukhan/fx/8088132/webrev.02/ Regards Prasanta